Making WordPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 3 months ago

#268 closed defect (bug) (fixed)

Update Quantcast script to support https without SSL erros

Reported by: ocean90's profile ocean90 Owned by: nacin's profile nacin
Milestone: Priority: normal
Component: General Keywords: has-patch
Cc:

Description

Reported by Mike.

The new code block:

<script type="text/javascript">
  var _qevents = _qevents || [];
  (function() {
   var elem = document.createElement('script');
   elem.src = (document.location.protocol == "https:" ? "https://secure" : "http://edge")
               + ".quantserve.com/quant.js";
   elem.async = true;
   elem.type = "text/javascript";
   var scpt = document.getElementsByTagName('script')[0];
   scpt.parentNode.insertBefore(elem, scpt);  
  })();
</script>

Source: Using the Quantcast Asynchronous Tag

Attachments (2)

268.patch (1.2 KB) - added by ocean90 11 years ago.
268.2.patch (1.3 KB) - added by mikemanger 11 years ago.
Load Quantcast script in head

Download all attachments as: .zip

Change History (6)

@ocean90
11 years ago

#1 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 223:

Trac: Update Quantcast tag to be async and SSL-aware.

props ocean90, mikemanger.
fixes #268.

@mikemanger
11 years ago

Load Quantcast script in head

#2 @mikemanger
11 years ago

Thanks for making the ticket.

The linked source recommends putting the first block at the end of the document's <head>. Not sure if it will break the tracking if it is not?

Otherwise, you can just merge the two script tags together.

This ticket was mentioned in PR #600 on WordPress/wporg-mu-plugins by @dd32.


3 months ago
#3

  • Keywords has-patch added

Fixes #268

The current admin bar links to the Profile edit, which can be confusing for some.

Before Proposed in PR
https://github.com/WordPress/wporg-mu-plugins/assets/767313/57305ae2-5588-4834-a46d-f4092854375f https://github.com/WordPress/wporg-mu-plugins/assets/767313/b8afa05a-7049-4945-bbd8-69b468dbf662

@dufresnesteven commented on PR #600:


3 months ago
#4

@dionysous Is this what you are expecting?

Note: See TracTickets for help on using tickets.