WordPress.org

Making WordPress.org

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#2688 closed defect (invalid)

Multiple Plugin Header Problem

Reported by: m_uysl Owned by:
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

As mentioned in plugin handbook;

Only one file in your plugin’s folder should have the header comment

Yes, but there is some edge cases.

I tried to submit new plugin with dropins which are located in includes/dropins/dropin-name.php and faced this issue. (still not sure it's an issue or not)

https://cloudup.com/cnCFDS43M80/f

Example: Jetpack has modules and some of modules has own header (like sharedaddy). If they were try to submit initial review today it wouldn’t work too.

IMHO, ideally looking root directory and one level depth could be better, like WordPress doing.

Change History (2)

#1 @m_uysl
3 months ago

  • Resolution set to invalid
  • Status changed from new to closed

Only one file in your plugin should have a plugin header. Regardless of what was accepted before.

@otto42 made clarification, marking as invalid.

#2 @Otto42
3 months ago

The problem here is that there have always been a bunch of weird edge cases that core and the directory have had to support, but realistically, it's one plugin, it should have one header. We're trying to make a better directory here, this is a case we can cleanup and enforce. Make your plugin one plugin. Easy.

Note: See TracTickets for help on using tickets.