WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

#269 closed defect (fixed)

Sponsors misaligned on 2012 Summit site

Reported by: iandunn Owned by:
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: has-patch
Cc:

Attachments (1)

269.diff (1.1 KB) - added by iandunn 3 years ago.

Download all attachments as: .zip

Change History (7)

@iandunn
3 years ago

#1 @iandunn
3 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
3 years ago

Would clear: left or clear: both make more sense than overflow: auto here?

#3 @iandunn
3 years ago

What's happening is that the images are floated, so they're not calculated when the browser determines the height of the containing paragraph. So, even though the paragraphs are already blocking, their heights are set to the height of the text, rather than the text + the image. That's what causes them to wrap the way they are. Setting overflow: auto triggers something in the browser to makes it recognize the image as part of the content of the container, so that the height gets set correctly.

More details about that vs clear are at http://www.sitepoint.com/simple-clearing-of-floats/

CSS isn't my strong-suit, though, so I'm happy to be corrected.

#4 @Otto42
3 years ago

In 294:

Add make-sitename to the body class, to allow for make site specific styling. See #269. props iandunn

#5 @Otto42
3 years ago

[294] adds a make-sitename class to the body instead. The CSS rules can be added using the Appearance->Edit CSS for each site, as needed.

Technically, the Edit CSS feature allows per site styling already, so the functions change is unnecessary, but I see value in having a site specific class there for later usage.

#6 @Otto42
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.