Opened 11 years ago
Closed 11 years ago
#269 closed defect (bug) (fixed)
Sponsors misaligned on 2012 Summit site
Reported by: | iandunn | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Make (Get Involved) / P2 | Keywords: | has-patch |
Cc: |
Description
http://make.wordpress.org/summit/sponsors/
The sponsor paragraphs aren't blocking because of the floated images.
xref: http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-01-07&sort=asc#m766405
Attachments (1)
Change History (7)
#3
@
11 years ago
What's happening is that the images are floated, so they're not calculated when the browser determines the height of the containing paragraph. So, even though the paragraphs are already blocking, their heights are set to the height of the text, rather than the text + the image. That's what causes them to wrap the way they are. Setting overflow: auto
triggers something in the browser to makes it recognize the image as part of the content of the container, so that the height gets set correctly.
More details about that vs clear
are at http://www.sitepoint.com/simple-clearing-of-floats/
CSS isn't my strong-suit, though, so I'm happy to be corrected.
#5
@
11 years ago
[294] adds a make-sitename class to the body instead. The CSS rules can be added using the Appearance->Edit CSS for each site, as needed.
Technically, the Edit CSS feature allows per site styling already, so the functions change is unnecessary, but I see value in having a site specific class there for later usage.
Would
clear: left
orclear: both
make more sense thanoverflow: auto
here?