Opened 7 years ago

Closed 7 years ago

#2690 closed defect (bug) (fixed)

Plugin Directory: Invalid subdomain links in translations list

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: ocean90's profile ocean90
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: has-patch


Background: Slack thread. links to, which does not exist.

The correct link for Brazilian Portuguese would have been

The locale cannot generally be used as subdomain, it needs to pull the associated subdomain from the locales table.

Attachments (1)

2690.patch (5.9 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (4)

7 years ago

#1 @SergeyBiryukov
7 years ago

  • Keywords has-patch commit added

The theme already pulls the list of locale sites in hreflang_link_attributes().

2690.patch moves that code to the plugin and reuses it in the translations section.

#2 @ocean90
7 years ago

  • Keywords commit removed
  • Owner set to ocean90
  • Status changed from new to accepted

Thanks for the patch. There's actually a new table which we'll use for that.

#3 @ocean90
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 5371:

Plugin Directory: Fix invalid subdomain links in translations list.

Our subdomains are not the same as locale slugs. To get the correct domains query the sites by WordPress locale.

See [5348].
Fixes #2690.

Note: See TracTickets for help on using tickets.