Making WordPress.org

Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#2696 closed enhancement (fixed)

Plugin Theme: Make Links accessible in Plugin Directory

Reported by: travel_girl's profile Travel_girl Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: has-screenshots ui-feedback has-patch needs-testing
Cc:

Description (last modified by SergeyBiryukov)

Links are not underlined in the Plugin Directory which makes it hard noticed that there are links, when they are in the middle of the text.

Also it can be impossible to see them as links, when people are colorblind or using the site, while the sun is really bride or on a beamer.

I suggest to underline the links who are in the middle of the text:

#description a:not(.button), a:not(.button):hover {
    text-decoration: underline;
}

#faq a:not(.button), a:not(.button):hover {
    text-decoration: underline;
}

Attachments (6)

Current_view_links_not_underlined.png (531.8 KB) - added by Travel_girl 7 years ago.
Current View, links are not underlined
Links_underlined.png (543.8 KB) - added by Travel_girl 7 years ago.
Suggestion: make links underlined in text
2696.diff (214.5 KB) - added by Travel_girl 7 years ago.
Patch: underline Links in Plugin directory
2696-theme.diff (866 bytes) - added by Travel_girl 7 years ago.
Underline theme author in Theme Directory
2696.site-title.png (4.3 KB) - added by SergeyBiryukov 7 years ago.
2696.2.diff (1.1 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (24)

@Travel_girl
7 years ago

Current View, links are not underlined

@Travel_girl
7 years ago

Suggestion: make links underlined in text

#1 @Travel_girl
7 years ago

  • Keywords has-screenshots added

#2 @samuelsidler
7 years ago

@mapk: Thoughts on adding underline here for accessibility?

#3 @SergeyBiryukov
7 years ago

  • Description modified (diff)

Adding the underline would be consistent with the changes made in #2542 for Support Theme.

Last edited 7 years ago by SergeyBiryukov (previous) (diff)

#4 @mapk
7 years ago

I'm for adding the underline, but then I question its consistency throughout. Should we also make ALL the links underlined? Or maybe just the links in the main content area and not in the sidebar?

Any thoughts?

Last edited 7 years ago by mapk (previous) (diff)

#5 @Travel_girl
7 years ago

I personal would not underlined the link in the sidebar, as they are standing alone (and not in the middle of text) so its easier to see them as links.

#6 @Ipstenu
7 years ago

  • Summary changed from Make Links accessible in Plugin Directory to Plugin Theme: Make Links accessible in Plugin Directory

#7 @melchoyce
7 years ago

  • Keywords ui-feedback added

#8 @Travel_girl
7 years ago

I just wrote a patch for that.

But the same issue is also in the Theme-directory.

@Travel_girl
7 years ago

Patch: underline Links in Plugin directory

#9 @Travel_girl
7 years ago

  • Keywords has-patch needs-testing added

This ticket was mentioned in Slack in #accessibility by travelgirl. View the logs.


7 years ago

@Travel_girl
7 years ago

Underline theme author in Theme Directory

This ticket was mentioned in Slack in #meta by travelgirl. View the logs.


7 years ago

#12 @SergeyBiryukov
7 years ago

2696.diff applies the underline globally, which results in some unintended side effects, e.g. the site-title heading has the underline as well: 2696.site-title.png.

Per discussion above, I think it's better to limit this to the content area. 2696.2.diff does just that. It would be consistent with Support Forums and the News blog.

#13 follow-up: @Travel_girl
7 years ago

I agree on that. Only the links in the content area needs to be underlined and the links in the locale-banner to translate the plugin.

#14 in reply to: ↑ 13 ; follow-up: @SergeyBiryukov
7 years ago

Replying to Travel_girl:

Only the links in the content area needs to be underlined and the links in the locale-banner to translate the plugin.

Not sure about the locale banner, the main https://wordpress.org/ site doesn't underline links there.

#15 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 5856:

Plugin Directory: Underline links in content area for better accessibility.

Props Travel_girl.
Fixes #2696.

#16 @SergeyBiryukov
7 years ago

In 5933:

Plugin Directory: Don't underline links styled as buttons.

See #2696.

This ticket was mentioned in Slack in #design by melchoyce. View the logs.


5 years ago

#18 in reply to: ↑ 14 @SergeyBiryukov
5 years ago

Replying to SergeyBiryukov:

Not sure about the locale banner, the main https://wordpress.org/ site doesn't underline links there.

Follow-up: #4250

Note: See TracTickets for help on using tickets.