WordPress.org

Making WordPress.org

Changes between Initial Version and Version 1 of Ticket #2710, comment 17


Ignore:
Timestamp:
04/18/2017 10:26:22 AM (5 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2710, comment 17

    initial v1  
    22> In the cases mentioned in the ticket, the cache for the authors (when only the contributor badge was showing as a fallback) or both caches (when neither badge appeared) had somehow gotten set with an empty array.
    33
    4 Found the culprit: [5287] switched `User_Badges::get_authors()` and `::get_contributors()` to use the corresponding methods from `\WordPressdotorg\Forums\(Plugin|Theme)`, but it doesn't account for the fact that badges are also displayed in some contexts where the plugin or theme object is not set up:
     4Found the culprit: [5287] switched `User_Badges::get_authors()` and `::get_contributors()` to use the corresponding methods from `\WordPressdotorg\Forums\(Plugin|Theme)`, but it doesn't account for the fact that `::get_badge_class()` is also called in some contexts where the plugin or theme object is not set up:
    55* When viewing "Plugins and Hacks", "Themes and Template", "Reviews" forums directly.
    66* In Spam/Pending/Archived moderator views.