WordPress.org

Making WordPress.org

Opened 4 months ago

Closed 3 months ago

#272 closed enhancement (fixed)

Trac: Replace icons with Dashicons

Reported by: ocean90 Owned by: ocean90
Priority: normal Component: Trac
Keywords: Cc:

Description


Attachments (5)

272.png (87.6 KB) - added by ocean90 4 months ago.
272.patch (3.1 KB) - added by ocean90 4 months ago.
272-time.png (9.0 KB) - added by netweb 3 months ago.
272-editor.patch (2.7 KB) - added by ocean90 3 months ago.
272.2.patch (4.7 KB) - added by ocean90 3 months ago.
editor, source browser

Download all attachments as: .zip

Change History (22)

ocean904 months ago

ocean904 months ago

comment:1 ocean904 months ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 250:

Trac: Replace icons on Timeline with Dashicons. fixes #272.

comment:2 nacin4 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Summary changed from Trac: Replace timeline icons with Dashicons to Trac: Replace icons with Dashicons

Since this changed a few other non-timeline icons (nice RSS icon!), I wonder if there are any other icons we could replace or add?

Here's what I'm finding so far:

  • Formatting toolbars (bold, italic, heading, link, code, hr, paragraph, line break, image, spellcheck (which is actually AtD's icon we position there)
  • Folder/file icons and expand/collapse arrows on /browser
  • Download icons
  • Edit/Reply/Delete comment buttons (and reply/delete for tickets), which are currently unicode characters already

In http://meta.trac.wordpress.org/prefs/userinterface, there's a "Use only symbols for buttons" option. Searching Trac core led me to a captioned_button method, which in addition to Edit/Reply/Delete mentioned above, is also used for Clear/Edit/Delete on reports. That's it, though. There's also a Clone ticket button but we don't have that plugin enabled.

comment:3 nacin4 months ago

In 256:

Trac: Rename 'User Interface' tab to 'Help Links' and remove the unnecessary icons option. see #272.

comment:4 nacin4 months ago

In 258:

Fix Help Links link. see #272, [256].

netweb3 months ago

comment:5 netweb3 months ago

'Milestone' via bbPress https://bbpress.trac.wordpress.org/timeline

Replace milestone.png with Dashicons "\f469"; (dashicons-clock)

Source: https://bbpress.trac.wordpress.org/chrome/common/css/timeline.css Line 62
dt.milestone, dt.milestone a { background-image: url(../milestone.png) !important }

comment:6 ocean903 months ago

In 281:

Trac: Replace milestone and wiki icons with Dashicons. Also use BuddyPress/bbPress colors for hover. see #272.

comment:7 follow-up: ocean903 months ago

[281] requires a Dashicons update for BuddyPress and bbPress trac.

comment:8 in reply to: ↑ 7 ocean903 months ago

Replying to ocean90:

[281] requires a Dashicons update for BuddyPress and bbPress trac.

Done in [282].

comment:9 nacin3 months ago

  • File downloads (attachments on tickets; files in the browser)
  • The goofy wheel thing on log and browser intended to symbolize the changeset resource. It would be awesome if we had an icon there that actually explained things, because I never remember whether to click the changeset number (which takes you to the log or browser as of that number) or the little cog. (We could also reverse the links, possibly, which makes more sense to me...)

ocean903 months ago

ocean903 months ago

editor, source browser

comment:10 ocean903 months ago

In 354:

Trac: Replace editor buttons with Dashicons. see #272.

comment:11 ocean903 months ago

In 355:

Trac: Replace link icons with Dashicons. see #272.

comment:12 ocean903 months ago

In 356:

Fix typo in [355], see #272.

comment:13 ocean903 months ago

In 357:

Trac: Replace source browser icons with Dashicons, see #272.

comment:14 ocean903 months ago

In 358:

Trac: Improve padding for download icons, remove icon from new ticket buttons, use Dashicon for keyword dismiss. see #272.

comment:15 ocean903 months ago

In 360:

Trac: Replace table sorting icons with Dashicons. see #272.

comment:16 ocean903 months ago

In 366:

Trac: Sync keyword dismiss templates. see #272.

comment:17 nacin3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Woohoo!

Note: See TracTickets for help on using tickets.