Making WordPress.org

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#2720 closed defect (bug) (fixed)

Sync WordCamp and Meetup.com event changes

Reported by: iandunn's profile iandunn Owned by: iandunn's profile iandunn
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: needs-patch good-first-bug
Cc:

Description (last modified by coreymckrill)

The Official WordPress Events plugin pulls in events from wordcamp.org and meetup.com and stores them in a local database, but it doesn't handle the case where events are changed or deleted. This results in deleted events being shown in the shortcode, and by api.wordpress.org/events.

Change History (14)

#1 @00Sleepy
7 years ago

Also you get double entrys of events which are deleted and recreated in the Dashboard Widget.

#2 @coreymckrill
7 years ago

Possibly related: I just got a report that meetup events with changed details are still showing the old details in the Dashboard widget (populated by the API).

#3 @coreymckrill
7 years ago

  • Owner set to coreymckrill
  • Status changed from new to accepted

#4 @coreymckrill
6 years ago

  • Description modified (diff)
  • Owner coreymckrill deleted
  • Status changed from accepted to assigned
  • Summary changed from Sync Meetup.com API deletions to Sync WordCamp and Meetup.com event changes

It turns out that this happens with WordCamp events as well. The example is WordCamp Milwaukie 2017, which was canceled, but still appears in the feed.

This ticket was mentioned in Slack in #meta by iandunn. View the logs.


6 years ago

#6 @iandunn
6 years ago

According to #3027, meetup.com will change the source_id when events are edited :|

One potential way to deal with this would be to add a cron job that queries meetup.com and wordcamp.org for all the upcoming events in the database, and then sync's their details.

Another way would be to add a multi-column unique key constraint to the database table. That would prevent duplicates from being inserted. We could detect if the INSERT failed for that reason, and then attempt an UPDATE instead.

This is closely related to #3027 and #3321, so I think we should take those into account when considering solutions. There may be an elegant solution which solves all of those cases; whereas coming up with 3 independent solutions could get messy.

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


6 years ago

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


6 years ago

This ticket was mentioned in Slack in #meta-wordcamp by sippis. View the logs.


6 years ago

This ticket was mentioned in Slack in #meta-wordcamp by mnelson4. View the logs.


6 years ago

#11 @mnelson4
6 years ago

I got this issue- I cancelled a meetup event and it still appears in the dashboard. What's especially great is that meetup.com doesn't let you edit a cancelled event!
I did find a workaround though (in case anyone else wants one):
-while looking at the cancelled event, I found the ID (a long string of random characters)
-I navigated to a non-cancelled event and click to edit it. Then I changed to the legacy editor.
-while editing the non-cancelled event, I changed its URL by replacing its ID with the cancelled event's ID
-I was then able to at least edit the event in meetup.com

This ticket was mentioned in Slack in #meta by sippis. View the logs.


6 years ago

#13 @iandunn
6 years ago

  • Owner set to iandunn
  • Resolution set to fixed
  • Status changed from assigned to closed

In 6814:

Official WordPress Events: Track status of events.

Events are sometimes cancelled, so we need to track that and only show those that are active. Otherwise they will continue to be displayed by the Events API and the [official_wordpress_events] shortcode.

This relies on r6810 to make the status of WordCamp events available, and on the new status column in EVENTS_TABLE.

Props coreymckrill, iandunn.
Fixes #2720.

#14 @iandunn
6 years ago

r6814 fixes 80% of the problem, but there's still a case where deleted Meetup events remain active in our database, see #3491.

Note: See TracTickets for help on using tickets.