WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 2 years ago

#2769 closed defect (fixed)

Header menu is not displayed on Rosetta sites without a custom menu

Reported by: SergeyBiryukov Owned by:
Milestone: Priority: normal
Component: International Sites (Rosetta) Keywords: has-patch has-screenshots
Cc:

Description

Background: comment:2:ticket:2618

On Rosetta sites that don't have a custom nav menu, the header menu falls back to wp_page_menu(), but the items are not displayed due to current styles in wp4.css. See an example on https://sah.wordpress.org/plugins/akismet/.

It's because wp_page_menu() has a bit different markup than wp_nav_menu() (it doesn't have an option to omit the container, see #WP33974):

<div id="wporg-header-menu" class="menu">
	<ul>
		...
	</ul>
</div>

vs.

<ul id="wporg-header-menu" class="menu">
	...
</ul>

The attached patch fixes the issue, see the screenshots. This doesn't explain why the Blog page is marked as current, but at least makes the header menu visible.

Attachments (3)

2769.PNG (17.1 KB) - added by SergeyBiryukov 3 years ago.
2769.patch (903 bytes) - added by SergeyBiryukov 3 years ago.
2769.after.PNG (22.5 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (5)

@SergeyBiryukov
3 years ago

@SergeyBiryukov
3 years ago

#1 @SergeyBiryukov
3 years ago

  • Keywords has-screenshots added

#2 @obenland
2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This appears to have been fixed with the switch to wporg-main.

Note: See TracTickets for help on using tickets.