#2790 closed enhancement (fixed)
Plugin Directory: Blockquote styles enhancement
Reported by: | webdevmattcrom | Owned by: | mapk |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Plugin Directory | Keywords: | has-patch ui-feedback 2nd-opinion |
Cc: |
Description
Currently, the blockquote styles on the single plugin page are almost invisible. Here's what they are currently:
blockquote { background: transparent; border: none; padding: 0; border-left: 2px solid #eee; color: #82878c; font-style: italic; margin: 16px 0; margin: 1rem 0; padding-left: 16px; padding-left: 1rem; }
I'd like to suggest this instead:
blockquote { background: #eee; border: none; color: #82878c; font-style: italic; margin: 16px 0; margin: 1rem 0; padding: 10px 40px; }
Attachments (5)
Change History (21)
#3
@
8 years ago
Thanks @ketuchetan -- I actually realized I didn't follow the standard padding sizing that the current styles employ. If possible, can you update your patch to this?
blockquote { background: #eee; border: none; color: #82878c; font-style: italic; margin: 16px 0; margin: 1rem 0; padding: 10px 40px; padding: 0.6em 2.5em; }
It's just adding that second padding rule.
This ticket was mentioned in Slack in #meta by chetansatasiya. View the logs.
8 years ago
This ticket was mentioned in Slack in #meta by chetansatasiya. View the logs.
8 years ago
#8
@
8 years ago
I don't think blockquote
should be italic. Blockquote can have nested HTML, including <em>
, which would be indistinguishable. I favor an indent, but not a background color change. After all, blockquote
is for quoting an external source, not making something stand out.
#9
@
7 years ago
- Milestone Plugin Directory v3.0 deleted
- Summary changed from Blockquote styles enhancement to Plugin Directory: Blockquote styles enhancement
Hello Guys,
I have added my patch as per the @webdevmattcrom suggestion.
Thanks,