WordPress.org
Get WordPress

Making WordPress.org

Opened 9 years ago

Closed 9 years ago

#2800 closed enhancement (fixed)

Plugin Directory: Ask for confirmation before removing someone as a committer

Reported by: Nikschavan Owned by: tellyworth
Priority: normal Milestone: Plugin Directory v3.0
Component: Plugin Directory Keywords: has-patch
Cc:

Description

The remove button only appears on hovering the committer name and can possibly be miss-clicked when clicking the name of committer.

When this link is clicked it deletes the committer without any confirmation.

https://cloudup.com/cCT8EknwddK+

Attachments (2)

2800.1.diff​ (2.3 KB ) - added by Nikschavan 9 years ago.
2800.2.diff​ (1.9 KB ) - added by SergeyBiryukov 9 years ago.

Download all attachments as: .zip

Change History (8)

@Nikschavan
9 years ago

#1 @Nikschavan
9 years ago

  • Keywords has-patch added

Attached a patch to ask for confirmation before deleting the committer.

@SergeyBiryukov
9 years ago

#2 @SergeyBiryukov
9 years ago

2800.2.diff​ uses an existing string from Customizations::enqueue_assets()​, which already has this confirmation when removing a committer on Edit Plugin page in the admin.

#3 @SergeyBiryukov
9 years ago

  • Milestone → Plugin Directory v3 - Future

This ticket was mentioned in ​Slack in #meta by tellyworth. ​View the logs.
9 years ago

#5 @SergeyBiryukov
9 years ago

  • Milestone Plugin Directory v3 - Future → Plugin Directory v3.0

The patch was approved at the latest plugin team meeting, so moving to the current milestone.

#6 @tellyworth
9 years ago

  • Owner set to tellyworth
  • Resolution → fixed
  • Status new → closed

In 5716:

Plugin directory: ask for confirmation before removing a committer. Props @Nikschavan

Fixes #2800

Note: See TracTickets for help on using tickets.