WordPress.org

Making WordPress.org

Opened 8 months ago

Closed 2 months ago

#2804 closed defect (fixed)

Plugin Directory: Plugin names are being grabbed from the wrong file

Reported by: Ipstenu Owned by: SergeyBiryukov
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: needs-patch
Cc:

Description

When you submit a plugin, it is SUPPOSED to scan the main plugin file for headers, and use that to generate the plugin slug and display name.

That scan should limit itself to the first folder, as otherwise it grabs the wrong data. Like if you've included a sub-plugin with headers it may grab those instead of yours.

Change History (5)

This ticket was mentioned in Slack in #meta by ipstenu. View the logs.


8 months ago

This ticket was mentioned in Slack in #meta by ipstenu. View the logs.


2 months ago

#3 @SergeyBiryukov
2 months ago

  • Keywords needs-patch added
  • Milestone set to Plugin Directory v3.0

This ticket was mentioned in Slack in #meta by ipstenu. View the logs.


2 months ago

#5 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 6026:

Plugin Directory: When searching for the main plugin file on upload, limit recursion depth to 1 level.

Scanning the deeper levels can grab the wrong data, e.g. if there's a sub-plugin with headers, it may be scanned instead of the main one.

Fixes #2804.

Note: See TracTickets for help on using tickets.