WordPress.org

Making WordPress.org

Opened 7 months ago

Closed 6 months ago

Last modified 6 months ago

#2811 closed defect (worksforme)

WordCamp.org: Disable Jetpack JITM

Reported by: kraftbj Owned by: coreymckrill
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords:
Cc:

Description

Jetpack has some "just-in-time messaging" to encourage site admins, etc to do things such as enable backups, etc. Since WordCamp Central has all those things setup, we probably should disable the messaging outright?

add_filter( 'jetpack_just_in_time_msgs', '__return_false', 11);

Change History (11)

#1 follow-up: @ocean90
7 months ago

Does [5323] not work?

#2 in reply to: ↑ 1 @richardmtl
7 months ago

Replying to ocean90:

Does [5323] not work?

I got a message yesterday on 2017.montreal.wordcamp.org asking to me backup my site, after I had Published a Ticket.

#3 @kraftbj
7 months ago

In [5323], it is filtering in a mu-plugin at priority 10, where it is then filtered later through Jetpack's normal processes also at 10, so I believe it is being trumped later.

It makes sense to me for Jetpack to reduce it down to 9 or change how it activates it (default true instead of false + add_filter) so it's easier to disable without knowing about the way Jetpack enables it, but until that is updated, using priority 11 should catch it.

#4 @coreymckrill
7 months ago

  • Owner set to coreymckrill
  • Status changed from new to accepted

#5 follow-up: @coreymckrill
7 months ago

Updated in r5477. I wasn't able to duplicate the problem before the update (maybe because super admin?) @richardmtl do you still see the messages if you publish another ticket?

#6 in reply to: ↑ 5 @richardmtl
7 months ago

Replying to coreymckrill:

Updated in r5477. I wasn't able to duplicate the problem before the update (maybe because super admin?) @richardmtl do you still see the messages if you publish another ticket?

I just created https://2017.montreal.wordcamp.org/wp-admin/post.php?post=409&action=edit

I got this message:

http://d.pr/i/U6dfh

#7 @coreymckrill
7 months ago

@richardmtl Ok, thanks. I will keep digging.

#8 @richardmtl
7 months ago

I got another one (the same "Backup" prompt) when setting up a ticket coupon.

#9 @coreymckrill
6 months ago

There was a change in [dotorg13221] that coincides with Jetpack v5.0 that might address this. It changes the priority for returning false on jetpack_just_in_time_msgs to 50.

@richardmtl Want to test again for me? :D

#10 @richardmtl
6 months ago

  • Resolution set to worksforme
  • Status changed from accepted to closed

@coreymckrill Created a test ticket and a test coupon, and neither showed the JITM. If I get any more, I'll re-open, but for now, Closing! :)

Note: See TracTickets for help on using tickets.