WordCamp.org: Disable Jetpack JITM

[kraftbj]

Jetpack has some "just-in-time messaging" to encourage site admins, etc to do things such as enable backups, etc. Since WordCamp Central has all those things setup, we probably should disable the messaging outright?

add_filter( 'jetpack_just_in_time_msgs', '__return_false', 11);

[ocean90]

Does [5323] not work?

[richardmtl]

Replying to ocean90:

Does [5323] not work?

I got a message yesterday on 2017.montreal.wordcamp.org asking to me backup my site, after I had Published a Ticket.

[kraftbj]

In [5323], it is filtering in a mu-plugin at priority 10, where it is then filtered later through Jetpack's normal processes also at 10, so I believe it is being trumped later.

It makes sense to me for Jetpack to reduce it down to 9 or change how it activates it (default true instead of false + add_filter) so it's easier to disable without knowing about the way Jetpack enables it, but until that is updated, using priority 11 should catch it.

[coreymckrill]

Updated in r5477. I wasn't able to duplicate the problem before the update (maybe because super admin?) @richardmtl do you still see the messages if you publish another ticket?

[richardmtl]

Replying to coreymckrill:

Updated in r5477. I wasn't able to duplicate the problem before the update (maybe because super admin?) @richardmtl do you still see the messages if you publish another ticket?

I just created ​https://2017.montreal.wordcamp.org/wp-admin/post.php?post=409&action=edit

I got this message:

​http://d.pr/i/U6dfh

[coreymckrill]

@richardmtl Ok, thanks. I will keep digging.

[richardmtl]

I got another one (the same "Backup" prompt) when setting up a ticket coupon.

[coreymckrill]

There was a change in [dotorg13221] that coincides with Jetpack v5.0 that might address this. It changes the priority for returning false on jetpack_just_in_time_msgs to 50.

@richardmtl Want to test again for me? :D

[richardmtl]

@coreymckrill Created a test ticket and a test coupon, and neither showed the JITM. If I get any more, I'll re-open, but for now, Closing! :)

[coreymckrill]

Yessss