Making WordPress.org

Opened 7 years ago

Closed 6 years ago

#2820 closed enhancement (fixed)

Add Japanese meetups to event API

Reported by: mayukojpn's profile mayukojpn Owned by:
Milestone: Priority: low
Component: WordCamp Site & Plugins Keywords: has-patch
Cc:

Description

Since we are not using meetup.com as event platform for localization reasons.

For now, we have own Google Calendar to list up events in Japan and add event by hand. https://calendar.google.com/calendar/embed?src=wpja.team@gmail.com

We are woking for listing groups on Google Spreadsheet as well:
https://docs.google.com/spreadsheets/d/18n6iktG_gn1SAbyGYfe8ZIw8Ca49l1fl8t_EBkrUGE8/edit#gid=0

Related: #1292
https://make.wordpress.org/community/2017/03/23/showing-upcoming-local-events-in-wp-admin/#comment-23211
https://github.com/coreymckrill/nearby-wordpress-events/issues/57

Attachments (3)

2820.diff (5.4 KB) - added by mayukojpn 7 years ago.
I checked this patch with shortcode. We should improve calling API logic. This calls API many times and I felt very slow.
2820-0.diff (4.8 KB) - added by mayukojpn 7 years ago.
FIrst patch has unrelated lines, sorry!
2820-auth.diff (4.6 KB) - added by coreymckrill 7 years ago.
work in progress

Download all attachments as: .zip

Change History (14)

#1 @mayukojpn
7 years ago

Does anyone know how I can see JSON output with local environment?

I could see my code was worked with shortcode in an old version of "Official WordPress Events" plugin, but I can't check with new version.

@mayukojpn
7 years ago

I checked this patch with shortcode. We should improve calling API logic. This calls API many times and I felt very slow.

@mayukojpn
7 years ago

FIrst patch has unrelated lines, sorry!

#2 @iandunn
7 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to iandunn
  • Status changed from new to accepted

Thanks! The patch looks pretty good.

It sounds like right now, the only the only Japanese meetup group that has joined the chapter program is Tokyo. We're only promoting events for official groups, so the other groups will need to join the chapter program before the could be listed.

I'll try to get this committed soon, so the Tokyo events show up in plenty of time for 4.8.

#3 follow-up: @coreymckrill
7 years ago

@mayukojpn I haven't been able to retrieve any events from the Doorkeeper API using either the URL format in the patch or the one in their API docs.

Example:

https://api.doorkeeper.jp/events?group_id=2504&time=0,3m

or

https://api.doorkeeper.jp/groups/2504/events

In the docs it says "API requests without authentication will fail", so I'm wondering if maybe you were able to get events because you were currently logged in with a Doorkeeper account, and I'm not?

We may need to set up a WordPress.org Community Team account on Doorkeeper and get an API token to get this to work...

cc @iandunn

#4 in reply to: ↑ 3 @iandunn
7 years ago

Replying to coreymckrill:

We may need to set up a WordPress.org Community Team account on Doorkeeper and get an API token to get this to work...

That makes sense. Do you see any obstacles to doing that?

#5 @coreymckrill
7 years ago

Update: I figured out how to get some events from the API. I signed up for a Doorkeeper account and got an API key, which allowed me to make authenticated requests. Anonymous requests are actually allowed also, but the request limit is very low, so if anyone else is making anonymous requests at the same time you might get locked out.

I also discovered that of all the group IDs listed in the array, only Tokyo WordPress Mokumoku Club has any events. Is that the one that's part of the chapter program?

#6 @coreymckrill
7 years ago

Do you see any obstacles to doing that?

We can probably just change the name/email address for the account I already created when the time comes.

This ticket was mentioned in Slack in #community-team by mayuko. View the logs.


7 years ago

@coreymckrill
7 years ago

work in progress

#8 @coreymckrill
7 years ago

  • Priority changed from normal to low

Adding 2820-auth.diff as a WIP patch. It builds on @mayukojpn's patch to add API authentication (though without a valid token at this point) and leverage more of Doorkeeper's API parameters.

Setting the priority to low since this is kind of on hold until we figure out how best to handle meetups like those in Japan that are on alternate platforms...

#9 @iandunn
7 years ago

It sounds like the Community Team would prefer to not bring in any more APIs just yet, but that might change in the future.

#10 @iandunn
7 years ago

  • Owner iandunn deleted
  • Status changed from accepted to assigned

#11 @coreymckrill
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Now that Wordbench is closing down and Japanese communities are migrating to Meetup.com (which has recently improved its Japanese localization), I think we can close this ticket.

Note: See TracTickets for help on using tickets.