Opened 7 years ago

Closed 7 years ago

#2841 closed defect (bug) (fixed)

Theme Directory - Feature filter has a min-height

Reported by: joyously's profile joyously Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Theme Directory Keywords: has-patch


When using the Feature Filter of the theme directory, there are 3 sections. Each section lists the filters and then has a big white space. Is there some aspect of the filters that isn't developed yet that is supposed to go in the white space?

Looking at the CSS, there is a class filter-group with a calculated width and min-height: 710px. Then another rule that overrides with width:100% and height: auto.

Can the min-height be removed, please?
(Actually, all four could be removed, but the min-height is the worst one.)

Attachments (1)

2841.patch (1.8 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (6)

This ticket was mentioned in Slack in #meta by joyously. View the logs.

7 years ago

#2 @SergeyBiryukov
7 years ago

Fixed height was originally added in [1034] and switched to min-height in [1543]. The commit included a hardcoded height of 710px and some JS code to increase the height for all filters if one of them gets higher due to longer strings.

However, [3622] has updated the list of features, 710px is no longer enough, and now that JS code always runs.

I think we could probably remove the fixed height. The page appears to be designed to mimic the theme install screen from WordPress core, which doesn't have fixed height for the filters.

#3 follow-up: @coffee2code
7 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 5739:

Theme Directory: Remove unnecessary min-height from .filter-group.

Props joyously, SergeyBiryukov.
Fixes #2841.

7 years ago

#4 in reply to: ↑ 3 @SergeyBiryukov
7 years ago

  • Keywords has-patch added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to coffee2code:

Theme Directory: Remove unnecessary min-height from .filter-group.

Removing min-height alone is not enough, the associated JS code added in [1543] for dynamically increasing the height of all filter columns should be removed as well.

See 2841.patch.

#5 @coffee2code
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5747:

Theme Directory: Remove JS for forcing equal heights of feature filter groups.

Props SergeyBiryukov.
Fixes #2841.

Note: See TracTickets for help on using tickets.