Making WordPress.org

#2845 closed defect (invalid)

Obsoleted strings are treated as approved in Credits API

Reported by: SergeyBiryukov Owned by:
Milestone: Priority: normal
Component: Translate Site & Plugins Keywords:

Description (last modified by SergeyBiryukov)

On the Credits page for 4.8 we have two contributors who don't appear to have any approved strings at any point (see the screenshots).

If I understand the process correctly:

  • Contributor provides a suggestion.
  • GTE neither approves nor rejects the suggestion, and makes their own translation instead.
  • The original suggestion now has an old status, which is treated as "Approved, but obsoleted by another translation".

Strings that weren't explicitly approved shouldn't be counted in credits.

That said, the "Approved by:" line is only displayed for current strings, not for old or rejected later, so there's no way in the UI to check whether those strings were ever approved. If they were, this ticket is invalid, but GlotPress should provide a way to check the history of status changes for any string via the UI.

Attachments (2)

2845.PNG (67.6 KB) - added by SergeyBiryukov 23 months ago.
2845.2.PNG (44.1 KB) - added by SergeyBiryukov 23 months ago.

Download all attachments as: .zip

Change History (5)

23 months ago

#1 @SergeyBiryukov
23 months ago

  • Description modified (diff)

#2 @SergeyBiryukov
23 months ago

  • Description modified (diff)

#3 @ocean90
23 months ago

  • Resolution set to invalid
  • Status changed from new to closed

The credits API isn't updated for 4.8 yet.

Note: See TracTickets for help on using tickets.