Making WordPress.org

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2861 closed task (blessed) (fixed)

Bring new homepage to localized sites

Reported by: ocean90's profile ocean90 Owned by: obenland's profile obenland
Milestone: Priority: normal
Component: International Sites (Rosetta) Keywords:
Cc:

Description

The current homepage of rosetta sites still uses the old design which is kind of confusing if you switch from wordpress.org to a locale specific site because the language banner told you so.

We should bring the new layout to the locale site and extend it with some local community things like upcoming events and we'd want to highlight the latest news, something the current homepage is lacking too.

Attachments (6)

2861-upcoming-events.png (210.7 KB) - added by ocean90 7 years ago.
2861-map.png (669.4 KB) - added by ocean90 7 years ago.
https://dd32.id.au/australian-wordpress-meetups-events/
2861-headings.png (66.7 KB) - added by SergeyBiryukov 7 years ago.
2861-powerful-features.png (48.0 KB) - added by SergeyBiryukov 7 years ago.
2861-alignment.png (75.0 KB) - added by SergeyBiryukov 7 years ago.
2861.diff (428 bytes) - added by DeFries 7 years ago.
Page Template for Downloads

Download all attachments as: .zip

Change History (101)

#1 @SergeyBiryukov
7 years ago

and we'd want to highlight the latest news, something the current homepage is lacking too.

Related: #1412

This ticket was mentioned in Slack in #meta by netweb. View the logs.


7 years ago

#3 @unintended8
7 years ago

Is there anything that can be done to help in this task? Maybe we just have to start with the new layout and then extending it with the new functionalities?

This ticket was mentioned in Slack in #polyglots by sergey. View the logs.


7 years ago

This ticket was mentioned in Slack in #meta by sergey. View the logs.


7 years ago

#6 @ocean90
7 years ago

  • Keywords needs-patch ui-feedback removed
  • Owner set to obenland
  • Status changed from new to assigned

#7 @obenland
7 years ago

In 5876:

WPorg: Add line-hight setting for XL buttons.

See #2861.

#8 @obenland
7 years ago

In 5877:

WPorg: Add a fallback header/footer for non-dotorg

See #2861.

#9 @obenland
7 years ago

In 5878:

Main: Include parent theme css changes in watch.

See #2861.

#10 @obenland
7 years ago

In 5879:

Main: Add front page template.

Brings the existing WordPress.org front page to the Main theme.
Still nneds work around pulling in News posts and some polish.

See #2861.

#11 @obenland
7 years ago

In 5883:

WPorg: Add basic 404 page.

Borrows most of it from the Plugin Directory.

See #2861.

#12 @obenland
7 years ago

In 5884:

WPorg: Add page template.

Uses the site title band for page titles.

See #2861.

#13 @obenland
7 years ago

In 5886:

Main: Use parent index file.

Moves Get page into its page template.

See #2861.

#14 @obenland
7 years ago

In 5887:

Main: Clear wporg header

Contains floated Rosetta menu items.

See #2861.

#15 @obenland
7 years ago

In 5889:

Main: Register Rosetta heeder menu.

Reverts [5887].
See #2861.

#16 @obenland
7 years ago

In 5891:

WPorg/Main: Pull teaser post from blog.

Also fixes to visual bugs where the pointer to the current menu item had the
wrong color and the divider to home below didn't show up.

See #2861.

#17 @obenland
7 years ago

In 5892:

WPorg/Main: First pass at blog-related templates.

See #2861.

#18 @obenland
7 years ago

In 5893:

Main: Add page template for releases.

Also removes sidebar from page content.

See #2861.

#19 @obenland
7 years ago

In 5939:

Main: Improve comments and entry meta styles.

Also regroups some component styles to a more appropriate location.

See #2861.

#20 @obenland
7 years ago

In 5940:

Main: Keep menu item highlight white for blog.

See #2861.

#21 @obenland
7 years ago

In 5942:

Main: Bring entry meta closer to existing styles.

Also adds the sidebar to single posts.

See #2861.

#22 @obenland
7 years ago

In 5945:

Main: Polishing up blog-related items

  • Decreases font-size of widget-area.
  • Introduces styles for sticky posts, galleries, and posts navigation.
  • Consistent margin between post meta and content.

See #2861.

#23 @obenland
7 years ago

In 5969:

Main: Improve mobile styles for blog

Includes a clever way to avoid having the posts navigation wrap on two lines.

See #2861.

#24 @obenland
7 years ago

In 5998:

Main: Introduce cube grid to manage small sceens

Adds a comfortable way to manage page structure and widget arrangement on small
screens.

See #2861.

#25 @obenland
7 years ago

In 6057:

Main: Adopt wporg textdomain.

Allows for both parent and child theme strings to be translated in one GlotPress project.

See #2861.

#26 @obenland
7 years ago

In 6058:

Main: Style updates.

  • Fixes a bug where pages were misaligned.
  • Underlines links in entry content and lists. Fixes #3216.
  • Improves comment metadata and reply.
  • Adds wporg header styles in case we ever get to a point where we can ditch wp4.css.

See #2861.

#27 @obenland
7 years ago

In 6060:

Main: Wrap global header in get_header() call

Makes sure we always get a rosetta menu, which is hooked into the get_header action.

Props dd32.
See #2861.

#28 @obenland
7 years ago

In 6063:

Main: Introduce Downloads page template

Also includes a brand new download button widget.

See #2861.

#29 @obenland
7 years ago

In 6065:

Main: Add theme screenshot

See #2861.

#30 @obenland
7 years ago

In 6068:

Main: Performance improvements

Added footer styles to one day remove wp4.css
Removed some unneeded resources
Switched to using optimized images for front page.

See #2861.

#31 @obenland
7 years ago

In 6091:

Main: Implement release rows for release archive

This was still missing from the original Rosetta theme, causing a fatal error on the releases page.
Also moves this into a slug-based page template, so it doesn't require editing the page after switching themes.

See #2861.

#32 @obenland
7 years ago

In 6092:

Main: Add missing textdomains.

Fixes a bug where translated strings would not be shown, due to the missing text domain.

H/t dd32.
See #2861.

#33 @obenland
7 years ago

In 6093:

Main: Just use alignright

It turns out that rtlcss takes care of flipping that direction for us.

See https://ur.wordpress.org/txt-download/
See #2861.

#34 @obenland
7 years ago

In 6096:

Main: Make some links localizable.

H/t dd32.
See #2861.

#35 @dd32
7 years ago

In 6098:

Main: Determine URLs for main pages which we know exist on Rosetta sites, avoiding the need to translate the URLs.

Ammends r6096.
See #2861.

#36 @netweb
7 years ago

Looking good, thanks for the work on this :+1:

Issues I see at the moment via https://en-au.wordpress.org

#37 follow-ups: @obenland
7 years ago

Thanks!

You can find the download button at https://en-au.wordpress.org/txt-download/.

As for the showcase, yes, we'll need to figure that out. And soon. Thanks for bringing it up!
Until we have a more permanent solution, maybe we could show them in the notable-users section?

#38 in reply to: ↑ 37 ; follow-up: @netweb
7 years ago

Replying to obenland:

You can find the download button at https://en-au.wordpress.org/txt-download/.

What about adding the button to the home page just as w.org does?

Though as can be seen in this screenshot #en-au would have issues with this due to the number of menu items 🤔

  • https://cldup.com/2Bw_gT3ihj.png

As for the showcase, yes, we'll need to figure that out. And soon. Thanks for bringing it up!
Until we have a more permanent solution, maybe we could show them in the notable-users section?

That would be one option, make that translatable for locales...

@dd32 also suggested in our local Slack:

Probably needs an iteration like the plugin directory, centralised translated showcase site

Personally I like the 2nd option, but thats ALOT MOAR work than the 1st option :P

#39 in reply to: ↑ 37 ; follow-up: @SergeyBiryukov
7 years ago

Replying to obenland:

You can find the download button at https://en-au.wordpress.org/txt-download/.

How does that help if that page is no longer included in the home page content and isn't linked to from anywhere? The download button should be in the header, same as on the main site, not at the bottom.

Another issue I see is that some headings are too narrow for translated strings. See 2861-headings.png — the first heading clashes with "News From Our Blog", the second one wraps to a new line.

As for the showcase, yes, we'll need to figure that out. And soon. Thanks for bringing it up!

The new forums theme used the opt-in approach initially and was only activated for all locales after all reported issues were fixed. Why was a different approach taken here?

Last edited 7 years ago by SergeyBiryukov (previous) (diff)

#40 @SergeyBiryukov
7 years ago

In the Powerful Features grid, localized sites don't have the middle vertical line. See 2861-powerful-features.png.

#41 in reply to: ↑ 38 @obenland
7 years ago

Replying to netweb:

What about adding the button to the home page just as w.org does?

Yeah, we could probably do that. It pretty much just takes the Download menu item and styles it like a button, so length of the menu shouldn't be too much of a concern initially.

[Showcase] needs an iteration like the plugin directory, centralised translated showcase site

Personally I like the 2nd option, but thats ALOT MOAR work than the 1st option :P

Yes, that is on the list of project ideas for the Meta team actually. So it's "just" a matter of time and resources :)

#42 in reply to: ↑ 39 ; follow-up: @obenland
7 years ago

Replying to SergeyBiryukov:

How does that help if that page is no longer included in the home page content and isn't linked to from anywhere? The download button should be in the header, same as on the main site, not at the bottom.

It's linked to from the "Get WordPress" button below the fold.
Let me find out how much magic is involved with the w.org header download button and see if we can duplicate that.

Another issue I see is that some headings are too narrow for translated strings. See 2861-headings.png — the first heading clashes with "News From Our Blog", the second one wraps to a new line.

How would you suggest to fix it?

The new forums theme used the opt-in approach initially and was only activated for all locales after all reported issues were fixed. Why was a different approach taken here?

Largely because I anticipated fixing any issues right away and not letting them become a problem. For now, the theme also doesn't get activated until it's 100% translated. But I'm happy to hold off switching other sites over if that makes you feel more comfortable

#43 @obenland
7 years ago

In 6099:

Main: Show middle divider in feature section

Fixes a bug with media queries, where the middle divider for Powerful Features wouldn't be displayed on large screens.

H/t SergeyBiryukov.
See #2861.

This ticket was mentioned in Slack in #forums by sergey. View the logs.


7 years ago

#45 follow-up: @obenland
7 years ago

In 6100:

Main: Turn download menu items into buttons

This will emulate w.org's behavior by turning any link to txt-download into a download button.

H/t netweb, SergeyBiryukov.
See #2861.

#46 @obenland
7 years ago

In 6101:

Main: Avoid current menu item stlyes

Maintains button visual, even if it's the current menu item.

See [6100].
See #2861.

#47 follow-up: @obenland
7 years ago

@netweb @SergeyBiryukov Adding a menu item that points to txt-download adds a download button now. Where yould be a good place to document that behavior?

#48 in reply to: ↑ 45 ; follow-up: @netweb
7 years ago

Replying to obenland:

This will emulate w.org's behavior by turning any link to txt-download into a download button.

Works for me, :+1:

Any chance of tweaking that bottom border or is that a limitation of the entire menu height?

https://cldup.com/M4Rshh5GlT.png

#49 @obenland
7 years ago

In 6102:

Main: Don't clear headings when floating grid item

See #2861.

#50 @obenland
7 years ago

In 6103:

Main: Make 404 page full-width

See #2861.

#51 in reply to: ↑ 47 @netweb
7 years ago

Replying to obenland:

@netweb @SergeyBiryukov Adding a menu item that points to txt-download adds a download button now. Where yould be a good place to document that behavior?

I think here would make sense https://make.wordpress.org/polyglots/handbook/rosetta/setting-up-your-local-site/

Still not easily discoverable though, what about making it a default menu entry for all sites and it to each site ?

#52 @obenland
7 years ago

In 6104:

Main: Temporarily disable stylesheet caching.

See #2861.

#53 in reply to: ↑ 48 @obenland
7 years ago

Replying to netweb:

Any chance of tweaking that bottom border or is that a limitation of the entire menu height?

Should be fixed now. It was stylesheet caching issue

Version 0, edited 7 years ago by obenland (next)

#54 in reply to: ↑ 42 ; follow-up: @SergeyBiryukov
7 years ago

Replying to obenland:

Largely because I anticipated fixing any issues right away and not letting them become a problem. For now, the theme also doesn't get activated until it's 100% translated.

Fair enough :)

@netweb @SergeyBiryukov Adding a menu item that points to txt-download adds a download button now. Where yould be a good place to document that behavior?

Per #1201, "Download" was supposed to be one of the default menu items, so I guess now is the time to add it to each site for consistency. If it's done automatically via a filter, I don't think it needs to be explicitly documented.

The txt-download slug doesn't make much sense long term though. It's an internal slug created when the page was a part of the home page layout. Now that it's an actual page, we should change it to download.

Last edited 7 years ago by SergeyBiryukov (previous) (diff)

#55 follow-up: @SergeyBiryukov
7 years ago

I think the text is supposed to be left-aligned with the page title, like on support forums. Currently it's not aligned, see 2861-alignment.png.

Last edited 7 years ago by SergeyBiryukov (previous) (diff)

#56 @SergeyBiryukov
7 years ago

The theme has ~25 strings in page-get.php that appear to be a leftover from the Plugin Directory and have nothing to do with the main site, but still need to be translated to get the project to 100%. Can we remove them from the project?

Last edited 7 years ago by SergeyBiryukov (previous) (diff)

#57 @obenland
7 years ago

In 6116:

Main: Remove Get page template.

It was meant as a shell for a future Get WordPress landing page but is unneeded at this point in time.

H/t dd32, SergeyBiryukov..
See #2861.

#58 in reply to: ↑ 55 @mapk
7 years ago

Replying to SergeyBiryukov:

I think the text is supposed to be left-aligned with the page title, like on support forums. Currently it's not aligned, see 2861-alignment.png.

If the page just has one column of text, it should be centered like this: https://codepen.io/mapk/pen/jrbKJr
If the page has two columns, then yes, it would look like the Support page mentioned.

#59 in reply to: ↑ 54 @SergeyBiryukov
7 years ago

Replying to SergeyBiryukov:

Per #1201, "Download" was supposed to be one of the default menu items, so I guess now is the time to add it to each site for consistency. If it's done automatically via a filter, I don't think it needs to be explicitly documented.

On second thought, if the goal is to keep it styled as a button and display it separately from the rest of the menu items, I think it should just be a part of the header template rather than a menu item.

The page it links to already exists on each site, so no additional logic should be necessary. The txt-download slug should still be changed to download though.

#60 @SergeyBiryukov
7 years ago

Alternatively, the slug could remain as is, and some code could be added to map /download/ to /txt-download/.

#61 follow-up: @SergeyBiryukov
7 years ago

[6100] and follow-up changes would also need to be ported to wporg-themes, wporg-plugins, and wporg-support themes, as they share the same menu and currently display a regular link instead of a button.

Last edited 7 years ago by SergeyBiryukov (previous) (diff)

#62 @obenland
7 years ago

In 6133:

Main: Use correct color for active menu items.

H/t ocean90.
See #2861.

#63 @obenland
7 years ago

In 6142:

Main: Bring back localized showcase teaser.

Also fixes line-breaking headlines in some locales.

H/t netveb.
See #2861.

#64 @obenland
7 years ago

In 6143:

WP.org: Always look for parent's inc folder.

Handles missing global header in child themes as well.

See #2861.

@DeFries
7 years ago

Page Template for Downloads

#65 @DeFries
7 years ago

Added a page template called Downloads that will, when selected, allow for a custom (translated) download URL.

#66 @obenland
7 years ago

In 6144:

WP.org: Better mocks of wporg header & footer

See #2861.

#67 @obenland
7 years ago

In 6145:

Main: Add a Download page template.

Allows localization of the download page slug.

Props DeFries.
See #2861.

#68 @obenland
7 years ago

In 6146:

Main: Show download buttons for pages with template.

See #2861.

#69 @obenland
7 years ago

In 6149:

WP.org: This seems inaccurate.

See #2861.

#70 @obenland
7 years ago

In 6150:

Main: Use market share constant for current values

See #2861.

#71 @obenland
7 years ago

In 6154:

WP.org: Make 404 hinge work.

Props mapk.
See #2861.

#72 in reply to: ↑ 61 ; follow-up: @SergeyBiryukov
7 years ago

Replying to SergeyBiryukov:

[6100] and follow-up changes would also need to be ported to wporg-themes, wporg-plugins, and wporg-support themes, as they share the same menu and currently display a regular link instead of a button.

Alternatively, nav_menu_objects() should be moved to a mu-plugin, as it doesn't make much sense to duplicate the code in four themes.

#73 in reply to: ↑ 72 @obenland
7 years ago

Replying to SergeyBiryukov:

Alternatively, nav_menu_objects() should be moved to a mu-plugin, as it doesn't make much sense to duplicate the code in four themes.

Agreed, I have a half-finished patch on my sandbox. Should be fixed by early next week (Thanksgiving).

#74 @obenland
7 years ago

In 6161:

Plugins: Updated wp.org header styles.

Adds the ability to handle download buttons on Rosetta sites.

See #2861.

#75 @SergeyBiryukov
7 years ago

In 6165:

Plugins: After [6161], add missing _breakpoint.scss file.

See #2861.

#76 @obenland
7 years ago

In 6171:

Breathe: Download button styles for Rosetta sites.

See #2861.

#77 @obenland
7 years ago

In 6173:

Main: Remove Download button handler.

Removed from the theme so it can be moved to a more central and rosetta-specific place.

See #2861.

#78 @obenland
7 years ago

In 6174:

Rosetta: Add Download Button handler.

Makes a link to the downloads page a button-style link like on wp.org.

See #2861.

#79 @obenland
7 years ago

In 6175:

Themes: Download button styles for Rosetta sites.

See #2861.

#80 @obenland
7 years ago

In 6177:

Support: Update wporg header styles.

Removes wp4.css dependancy and accounts for download button on Rosetta sites.

See #2861.

#81 follow-ups: @obenland
7 years ago

The download button is now being displayed across themes/plugins/support/p2 themes as well.

@SergeyBiryukov @netweb I think this concludes the items that you brought up?
@ocean90 What do you think about creating new tickets for enhancements past bringing the w.org homepage to Rosetta sites?

#82 in reply to: ↑ 81 @netweb
7 years ago

Replying to obenland:

The download button is now being displayed across themes/plugins/support/p2 themes as well.

@SergeyBiryukov @netweb I think this concludes the items that you brought up?

Yup, looking great, thanks for your work on this :+1:

#83 in reply to: ↑ 81 @ocean90
7 years ago

Replying to obenland:

@ocean90 What do you think about creating new tickets for enhancements past bringing the w.org homepage to Rosetta sites?

Fine by me. There's already #3288 and #3289.

#84 @obenland
7 years ago

In 6194:

Main: Avoid overflow breaking layout.

See #2861.

#85 @obenland
7 years ago

In 6200:

Main: Stify blog sidebar.

Fixes a bug on sites with outdated sidebar data, where it wouldn't show a sidebar.

See #2861.

#86 @obenland
7 years ago

In 6201:

Main: Introduce search archive page.

Better styles for mixed-post-type search results.
Also properly displays the template for empty search results now.

See #2861.

#87 @obenland
7 years ago

In 6203:

Main: Check if $rosetta exists.

Makes is easier to run the theme locally and outside of the context of a Rosetta site.

See #2861.

#88 @obenland
7 years ago

In 6205:

Main: Use correct srcset descriptor.

See #2861.

#89 @obenland
7 years ago

In 6206:

Main: Use correct file extension for swag image.

See #2861.

#90 @obenland
7 years ago

In 6211:

WPorg: Opt out of global header styles.

Moves to using the CDN for main theme styles and only loads the dependencies it really needs.

See #2861.

#91 @obenland
7 years ago

In 6214:

Main: Remove wp4.css fixes.

Now that we don't have that dependency anymore, we can shed those overrides as well.

See #2861.

#92 @obenland
7 years ago

In 6277:

Main: Conform to WPCS.

See #2861.

#93 @obenland
7 years ago

In 6278:

Main: Improve fornt page footer responsiveness

Makes better use of screen real estate on small screens.

Reverts [6247].
See #2861.

#94 @obenland
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

#95 @coffee2code
7 years ago

In 6321:

Theme Directory: Update style-rtl.css with styles added in [6175].

See #2861.

Note: See TracTickets for help on using tickets.