#2861 closed task (blessed) (fixed)
Bring new homepage to localized sites
Reported by: | ocean90 | Owned by: | obenland |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | International Sites (Rosetta) | Keywords: | |
Cc: |
Description
The current homepage of rosetta sites still uses the old design which is kind of confusing if you switch from wordpress.org to a locale specific site because the language banner told you so.
We should bring the new layout to the locale site and extend it with some local community things like upcoming events and we'd want to highlight the latest news, something the current homepage is lacking too.
Attachments (6)
Change History (101)
#1
@
7 years ago
and we'd want to highlight the latest news, something the current homepage is lacking too.
Related: #1412
This ticket was mentioned in Slack in #meta by netweb. View the logs.
7 years ago
#3
@
7 years ago
Is there anything that can be done to help in this task? Maybe we just have to start with the new layout and then extending it with the new functionalities?
This ticket was mentioned in Slack in #polyglots by sergey. View the logs.
7 years ago
This ticket was mentioned in Slack in #meta by sergey. View the logs.
7 years ago
#6
@
7 years ago
- Keywords needs-patch ui-feedback removed
- Owner set to obenland
- Status changed from new to assigned
#36
@
7 years ago
Looking good, thanks for the work on this :+1:
Issues I see at the moment via https://en-au.wordpress.org
- The localised showcase is missing eg: https://en-gb.wordpress.org/#showcase
- No download button
#37
follow-ups:
↓ 38
↓ 39
@
7 years ago
Thanks!
You can find the download button at https://en-au.wordpress.org/txt-download/.
As for the showcase, yes, we'll need to figure that out. And soon. Thanks for bringing it up!
Until we have a more permanent solution, maybe we could show them in the notable-users section?
#38
in reply to:
↑ 37
;
follow-up:
↓ 41
@
7 years ago
Replying to obenland:
You can find the download button at https://en-au.wordpress.org/txt-download/.
What about adding the button to the home page just as w.org does?
Though as can be seen in this screenshot #en-au would have issues with this due to the number of menu items 🤔
As for the showcase, yes, we'll need to figure that out. And soon. Thanks for bringing it up!
Until we have a more permanent solution, maybe we could show them in the notable-users section?
That would be one option, make that translatable for locales...
@dd32 also suggested in our local Slack:
Probably needs an iteration like the plugin directory, centralised translated showcase site
Personally I like the 2nd option, but thats ALOT MOAR work than the 1st option :P
#39
in reply to:
↑ 37
;
follow-up:
↓ 42
@
7 years ago
Replying to obenland:
You can find the download button at https://en-au.wordpress.org/txt-download/.
How does that help if that page is no longer included in the home page content and isn't linked to from anywhere? The download button should be in the header, same as on the main site, not at the bottom.
Another issue I see is that some headings are too narrow for translated strings. See 2861-headings.png — the first heading clashes with "News From Our Blog", the second one wraps to a new line.
As for the showcase, yes, we'll need to figure that out. And soon. Thanks for bringing it up!
The new forums theme used the opt-in approach initially and was only activated for all locales after all reported issues were fixed. Why was a different approach taken here?
#40
@
7 years ago
In the Powerful Features grid, localized sites don't have the middle vertical line. See 2861-powerful-features.png.
#41
in reply to:
↑ 38
@
7 years ago
Replying to netweb:
What about adding the button to the home page just as w.org does?
Yeah, we could probably do that. It pretty much just takes the Download menu item and styles it like a button, so length of the menu shouldn't be too much of a concern initially.
[Showcase] needs an iteration like the plugin directory, centralised translated showcase site
Personally I like the 2nd option, but thats ALOT MOAR work than the 1st option :P
Yes, that is on the list of project ideas for the Meta team actually. So it's "just" a matter of time and resources :)
#42
in reply to:
↑ 39
;
follow-up:
↓ 54
@
7 years ago
Replying to SergeyBiryukov:
How does that help if that page is no longer included in the home page content and isn't linked to from anywhere? The download button should be in the header, same as on the main site, not at the bottom.
It's linked to from the "Get WordPress" button below the fold.
Let me find out how much magic is involved with the w.org header download button and see if we can duplicate that.
Another issue I see is that some headings are too narrow for translated strings. See 2861-headings.png — the first heading clashes with "News From Our Blog", the second one wraps to a new line.
How would you suggest to fix it?
The new forums theme used the opt-in approach initially and was only activated for all locales after all reported issues were fixed. Why was a different approach taken here?
Largely because I anticipated fixing any issues right away and not letting them become a problem. For now, the theme also doesn't get activated until it's 100% translated. But I'm happy to hold off switching other sites over if that makes you feel more comfortable
This ticket was mentioned in Slack in #forums by sergey. View the logs.
7 years ago
#47
follow-up:
↓ 51
@
7 years ago
@netweb @SergeyBiryukov Adding a menu item that points to txt-download
adds a download button now. Where yould be a good place to document that behavior?
#48
in reply to:
↑ 45
;
follow-up:
↓ 53
@
7 years ago
Replying to obenland:
This will emulate w.org's behavior by turning any link to
txt-download
into a download button.
Works for me, :+1:
Any chance of tweaking that bottom border or is that a limitation of the entire menu height?
#51
in reply to:
↑ 47
@
7 years ago
Replying to obenland:
@netweb @SergeyBiryukov Adding a menu item that points to
txt-download
adds a download button now. Where yould be a good place to document that behavior?
I think here would make sense https://make.wordpress.org/polyglots/handbook/rosetta/setting-up-your-local-site/
Still not easily discoverable though, what about making it a default menu entry for all sites and it to each site ?
#53
in reply to:
↑ 48
@
7 years ago
Replying to netweb:
Any chance of tweaking that bottom border or is that a limitation of the entire menu height?
Should be fixed now. It was stylesheet caching issue
#54
in reply to:
↑ 42
;
follow-up:
↓ 59
@
7 years ago
Replying to obenland:
Largely because I anticipated fixing any issues right away and not letting them become a problem. For now, the theme also doesn't get activated until it's 100% translated.
Fair enough :)
@netweb @SergeyBiryukov Adding a menu item that points to
txt-download
adds a download button now. Where yould be a good place to document that behavior?
Per #1201, "Download" was supposed to be one of the default menu items, so I guess now is the time to add it to each site for consistency. If it's done automatically via a filter, I don't think it needs to be explicitly documented.
The txt-download
slug doesn't make much sense long term though. It's an internal slug created when the page was a part of the home page layout. Now that it's an actual page, we should change it to download
.
#55
follow-up:
↓ 58
@
7 years ago
I think the text is supposed to be left-aligned with the page title, like on support forums. Currently it's not aligned, see 2861-alignment.png.
#56
@
7 years ago
The theme has ~25 strings in page-get.php that appear to be a leftover from the Plugin Directory and have nothing to do with the main site, but still need to be translated to get the project to 100%. Can we remove them from the project?
#58
in reply to:
↑ 55
@
7 years ago
Replying to SergeyBiryukov:
I think the text is supposed to be left-aligned with the page title, like on support forums. Currently it's not aligned, see 2861-alignment.png.
If the page just has one column of text, it should be centered like this: https://codepen.io/mapk/pen/jrbKJr
If the page has two columns, then yes, it would look like the Support page mentioned.
#59
in reply to:
↑ 54
@
7 years ago
Replying to SergeyBiryukov:
Per #1201, "Download" was supposed to be one of the default menu items, so I guess now is the time to add it to each site for consistency. If it's done automatically via a filter, I don't think it needs to be explicitly documented.
On second thought, if the goal is to keep it styled as a button and display it separately from the rest of the menu items, I think it should just be a part of the header template rather than a menu item.
The page it links to already exists on each site, so no additional logic should be necessary. The txt-download
slug should still be changed to download
though.
#60
@
7 years ago
Alternatively, the slug could remain as is, and some code could be added to map /download/
to /txt-download/
.
#61
follow-up:
↓ 72
@
7 years ago
[6100] and follow-up changes would also need to be ported to wporg-themes
, wporg-plugins
, and wporg-support
themes, as they share the same menu and currently display a regular link instead of a button.
#65
@
7 years ago
Added a page template called Downloads that will, when selected, allow for a custom (translated) download URL.
#72
in reply to:
↑ 61
;
follow-up:
↓ 73
@
7 years ago
Replying to SergeyBiryukov:
[6100] and follow-up changes would also need to be ported to
wporg-themes
,wporg-plugins
, andwporg-support
themes, as they share the same menu and currently display a regular link instead of a button.
Alternatively, nav_menu_objects()
should be moved to a mu-plugin, as it doesn't make much sense to duplicate the code in four themes.
#73
in reply to:
↑ 72
@
7 years ago
Replying to SergeyBiryukov:
Alternatively,
nav_menu_objects()
should be moved to a mu-plugin, as it doesn't make much sense to duplicate the code in four themes.
Agreed, I have a half-finished patch on my sandbox. Should be fixed by early next week (Thanksgiving).
#81
follow-ups:
↓ 82
↓ 83
@
7 years ago
The download button is now being displayed across themes/plugins/support/p2 themes as well.
@SergeyBiryukov @netweb I think this concludes the items that you brought up?
@ocean90 What do you think about creating new tickets for enhancements past bringing the w.org homepage to Rosetta sites?
#82
in reply to:
↑ 81
@
7 years ago
Replying to obenland:
The download button is now being displayed across themes/plugins/support/p2 themes as well.
@SergeyBiryukov @netweb I think this concludes the items that you brought up?
Yup, looking great, thanks for your work on this :+1:
https://dd32.id.au/australian-wordpress-meetups-events/