WordPress.org

Making WordPress.org

Opened 5 months ago

Closed 13 days ago

Last modified 5 days ago

#2871 closed defect (fixed)

Remove Nav-newer and Nav-older links below Handbook Content

Reported by: andrealeebishop Owned by: coffee2code
Milestone: Priority: normal
Component: Handbooks Keywords:
Cc:

Description

On a page like Get Involved there are links at the bottom (← Current Docs Projects, Code Reference →) that would make sense if the content were chronological. But the content isn't date-based (except for in the weekly meeting posts).

Would it be possible to remove that unnecessary navigation from the bottom of Handbook pages in the theme?

Slack convo

Change History (7)

#1 follow-up: @thewebprincess
5 months ago

I agree that the current links are problematic when they go from older to newer, I would like to propose instead that these be more logical and flow through the content from the current page to the next most logical in the sequence.

I believe it would make the handbook more useful to lead people through the content and these links would do that very well, IF we had control over them rather than them being created automatically.

#2 in reply to: ↑ 1 @andrealeebishop
5 months ago

Replying to thewebprincess:

propose instead that these be more logical and flow through the content from the current page to the next most logical in the sequence.

Isn't that redundant with the navigation on the sidebar?

This ticket was mentioned in Slack in #docs by bishop. View the logs.


5 months ago

#4 @coffee2code
13 days ago

In 6084:

Handbook plugin: Fix post navigation when using widget.

  • Use parent page as first child's 'previous' adjacent page.
  • Use page's first child as its 'next' adjacent page.
  • For last leaf node, recursively check ancestors for their 'next' sibling.
  • Fix to properly order by menu_order then by post_title, when ordering by menu_order.
  • Fix navigation for pages with lots of siblings.
  • Enable navigation to work to/from/on private pages.

See #2871.

#5 @coffee2code
13 days ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 6085:

Handbook plugin: Add compatibility with o2 to override its default post navigation handling.

Fixes #2871.

#6 @coffee2code
13 days ago

Hi!

So I've resolved the ticket while not doing what was explicitly requested. The desire to remove the handbook page-to-page navigation was no doubt brought on by the fact that the navigation behaved incorrectly. I've fixed the issues it had (in the commits cited above) and now it appears to navigate properly (and can thus remain).

#7 @ocean90
5 days ago

In 6125:

Handbook plugin: Don't compare the result of array_keys() against false, it only returns an array or null.

Avoids a PHP warning if there are no previous and next handbook pages.

See #2871.

Note: See TracTickets for help on using tickets.