Making WordPress.org

Opened 4 years ago

Closed 4 years ago

#2877 closed defect (fixed)

Mistyped placeable

Reported by: tobifjellner Owned by: Otto42
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: has-patch


A placeable is lacking a percent sign.

We recommend using %1s as it will allow
Should be changed to
We recommend using %1$s as it will allow

File: https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php
Appr. location: 171--180

                        $readme = $this->find_readme_file();
                        if ( empty( $readme ) ) {
                                $error = __( 'Error: The plugin has no readme.', 'wporg-plugins' );
                                /* translators: 1: readme.txt, 2: readme.md */
                                return $error . ' ' . sprintf( __( 'The zip file must include a file named %1$s or %2$s. We recommend using %1s as it will allow you to fully utilize our directory.', 'wporg-plugins' ),

Attachments (1)

2877.patch (1.0 KB) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (4)

#1 in reply to: ↑ description @tobifjellner
4 years ago

Sorry, it's a dollar character missing. (the percent sign is there... :)

4 years ago

#2 @SergeyBiryukov
4 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone set to Plugin Directory v3.0

Good catch, introduced in [5574].

#3 @Otto42
4 years ago

  • Owner set to Otto42
  • Resolution set to fixed
  • Status changed from new to closed

In 5583:

Plugin Directory: Fill in missing $ sign for translatable text. props @tobifjellner @SergeyBiryukov. Fixes #2877

Note: See TracTickets for help on using tickets.