Opened 7 years ago

Closed 4 years ago

#2885 closed defect (bug) (fixed) Remove hardcoded CSS from translatable strings

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by:
Milestone: Priority: low
Component: WordCamp Site & Plugins Keywords: has-patch


Some strings in WordCamp_New_Site::get_stub_posts() have hardcoded CSS that doesn't need to be translated.

Attachments (1)

2885.patch (2.9 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (5)

7 years ago

#1 @iandunn
7 years ago

  • Owner set to iandunn
  • Priority changed from normal to low
  • Status changed from new to accepted

I think those strings can be de-internationalized entirely, it was a mistake to internationalize them, since the posts get created before a site locale is assigned. See ticket:603#comment:2.

Or, we could try to set a locale on the wordcamp post type, but that'd require extra work from the Community team, and might have some technical issues that need to be sorted out. It'd probably require a discussion on make/Community first to sort out what they want to do.

#2 @iandunn
7 years ago

  • Owner iandunn deleted
  • Status changed from accepted to assigned

This ticket was mentioned in Slack in #meta-wordcamp by ryelle. View the logs.

4 years ago

#4 @ryelle
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in PR 445 on github, by removing the translation wrappers from these strings.

Note: See TracTickets for help on using tickets.