Plugin Directory Admin: Change "Mark as Pending" to "Pend"

[Ipstenu]

tl;dr the text is too long and causes a wrap-around :D

[ocean90]

• Why is there no text domain for these strings?
• Not all translators would understand that "Pend" means "Pending", some languages probably don't even have such an abbreviation.
• Having each button on its own line looks more sane/future-proof.

[SergeyBiryukov]

Replying to ocean90:

Why is there no text domain for these strings?

My bad, missed in [5573].

Having each button on its own line looks more sane/future-proof.

That was my initial thought as well, it just looked a bit weird, so I went with a single row in the first iteration.

2891.2.diff​ adds the text domain and moves each button to its own line: 2891.PNG​.

P.S. On WCEU contributor day I've noticed that creating patches from the root of the meta repository causes them to not apply properly. What would be the preferred root directory? sites/trunk/wordpress.org/public_html/, maybe?

[ocean90]

Replying to SergeyBiryukov:

P.S. On WCEU contributor day I've noticed that creating patches from the root of the meta repository causes them to not apply properly. What would be the preferred root directory? sites/trunk/wordpress.org/public_html/, maybe?

I personally don't have the sites directory in my SVN checkout because it's unnecessary. I guess that's the reason why the git mirror doesn't even have that extra directory.

---

2891.2.diff​ looks good.

[Ipstenu]

Having each button on its own line looks more sane/future-proof.

God, I really hope we don't have more than 3 at any one point in time. Each on it's own line is clutter to me.

We used to just have four (let it ride, reply to author, reject, approve), but we don't need one 'let it ride' anymore since that's the draft status, and if we just save it does that.

[coffee2code]

@Ipstenu: Are you on board with having each button on its line, perhaps with a revisit should we ever get 4+ there and it becomes too cluttered for you?

[Ipstenu]

I'd rather not have it be each on their own line, since that makes it look really bad on mobile (yes, I review plugins on my phone sometimes).

If it has proper padding, I don't mind the wrap-around, but right now it's only got side-side padding, and nothing for top-bottom.

[SergeyBiryukov]

Replying to Ipstenu:

If it has proper padding, I don't mind the wrap-around, but right now it's only got side-side padding, and nothing for top-bottom.

Here's how it looks for me in Chrome dev tools' iPhone 5 emulation: 2891.2.PNG​. Do you see something different? Could you add a screenshot?

[SergeyBiryukov]

Moved the patch for missing text domains to separate ticket: #2993.

[Ipstenu]

Here's how it CURRENTLY looks on Safari

[Ipstenu]

Chrome would be why :) I use Safari and it looks like https://meta.trac.wordpress.org/attachment/ticket/2891/2891.safari.png on laptop and iOS.

[tellyworth]

In 5715:

Plugin directory admin: improve buttons in the Plugin Controls metabox. Props @SergeyBiryukov

Fixes #2891