Making WordPress.org

Opened 7 years ago

Closed 4 years ago

#2894 closed defect (bug) (fixed)

Admin Flags: Internationalise the post-status-change label

Reported by: dd32's profile dd32 Owned by: coreymckrill's profile coreymckrill
Milestone: Priority: low
Component: WordCamp Site & Plugins Keywords: has-patch
Cc:

Description

When toggling a status in the Flag section, the toggle afterwards is missing the capitalisation, this is because it just sets the label afterwards to the command, rather than the textual label for it.

The attached patch adds internationalised Enable/Disable text which it switches in/out instead of using the command. It's hard-coded inline with the JS, as that's the format of the current JS and changing it up further probably deserves a rethink of the entire flagging UI and storage.

Attachments (1)

camptix-add-i18n-flag-labels.diff (2.5 KB) - added by dd32 7 years ago.

Download all attachments as: .zip

Change History (5)

#1 @coreymckrill
7 years ago

  • Owner set to coreymckrill
  • Status changed from new to accepted

#2 @iandunn
6 years ago

  • Priority changed from normal to low

This ticket was mentioned in Slack in #meta-wordcamp by ryelle. View the logs.


4 years ago

#4 @ryelle
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Merged in 6bd7068.

Note: See TracTickets for help on using tickets.