Opened 7 years ago
Last modified 13 months ago
#2902 new enhancement
Add PHPCS to theme upload process
Reported by: | grapplerulrich | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Theme Review | Keywords: | has-patch |
Cc: |
Description
As we are working on a PHPCS ruleset that we can apply to WordPress Themes this should run during the upload process.
Change History (11)
This ticket was mentioned in Slack in #themereview by grapplerulrich. View the logs.
7 years ago
#3
@
7 years ago
What needs to be done to get to the point where theme uploads can be blocked by errors from the theme sniffer?
This ticket was mentioned in Slack in #themereview by poena. View the logs.
7 years ago
This ticket was mentioned in Slack in #themereview by poena. View the logs.
7 years ago
#6
follow-up:
↓ 7
@
5 years ago
@grapplerulrich Should we close this in favor of Tide and what we discussed at WCEU (about migrating WPThemeReview to the .org repo etc.)?
#7
in reply to:
↑ 6
@
5 years ago
Replying to dingo_d:
@grapplerulrich Should we close this in favor of Tide and what we discussed at WCEU (about migrating WPThemeReview to the .org repo etc.)?
Lets keep this open, as we still need to implement something here (Be it Tide or something else)
This ticket was mentioned in Slack in #themereview by dingo_d. View the logs.
5 years ago
#9
@
4 years ago
Leaving a note about these two GitHub repositories for reference
https://github.com/WordPress/theme-review-action
https://github.com/WordPress/theme-review-e2e
I have been working on a way of getting the new theme sniffs onto WordPress.org
I have added a few file
sniff.php
to Theme-Check which will only be used on w.org. https://github.com/WordPress/theme-check/commits/feature/new-sniffsI have also tested the code to integrated the checks in the upload process. I have removed the testing of JS files for the time being. Only errors will be checked for the moment so there will be no warnings from the sniffs.
https://github.com/grappler/meta-environment/commit/917e13e9abf2c927c0f24f8a1b64a1c4bbac0238
To be fair the code could be better but I think we should get a version of w.org and then see how that goes and work from there.
For developers I think it is better for theme authors to use https://github.com/WPTRT/ns-theme-check/ for the time being.