WordPress.org

Making WordPress.org

Opened 11 months ago

Last modified 2 months ago

#2902 new enhancement

Add PHPCS to theme upload process

Reported by: grapplerulrich Owned by:
Milestone: Priority: normal
Component: Theme Review Keywords: has-patch
Cc:

Description

As we are working on a PHPCS ruleset that we can apply to WordPress Themes this should run during the upload process.

https://github.com/WPTRT/WordPress-Coding-Standards

Change History (5)

#1 @grapplerulrich
11 months ago

  • Keywords has-patch added

I have been working on a way of getting the new theme sniffs onto WordPress.org
I have added a few file sniff.php to Theme-Check which will only be used on w.org. https://github.com/WordPress/theme-check/commits/feature/new-sniffs
I have also tested the code to integrated the checks in the upload process. I have removed the testing of JS files for the time being. Only errors will be checked for the moment so there will be no warnings from the sniffs.
https://github.com/grappler/meta-environment/commit/917e13e9abf2c927c0f24f8a1b64a1c4bbac0238
To be fair the code could be better but I think we should get a version of w.org and then see how that goes and work from there.
For developers I think it is better for theme authors to use https://github.com/WPTRT/ns-theme-check/ for the time being.

This ticket was mentioned in Slack in #themereview by grapplerulrich. View the logs.


11 months ago

#3 @joyously
9 months ago

What needs to be done to get to the point where theme uploads can be blocked by errors from the theme sniffer?

This ticket was mentioned in Slack in #themereview by poena. View the logs.


4 months ago

This ticket was mentioned in Slack in #themereview by poena. View the logs.


2 months ago

Note: See TracTickets for help on using tickets.