WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 2 years ago

#2914 closed enhancement (fixed)

WordCamp Docs: Add a currency field for the sponsorship agreement

Reported by: coreymckrill Owned by: coreymckrill
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch
Cc:

Description

The sponsorship agreement template has USD hard-coded as the currency type when it generates a PDF to send to a prospective WordCamp sponsor. However, sponsors are allowed to pay their sponsorship in the local currency where the WordCamp is located, and this is often the easiest choice for them.

This enhancement needs two components:

  • An additional field to specify the currency type
  • Including and sanitizing the currency type in the template file used to generate the PDF

Attachments (1)

2914.patch (2.2 KB) - added by tyxla 2 years ago.
Do not hardcode currency in the sponsorship agreement template. Add a hint for adding the currency to the amount fields.

Download all attachments as: .zip

Change History (4)

#1 @coreymckrill
2 years ago

  • Owner set to coreymckrill
  • Status changed from new to accepted

@tyxla
2 years ago

Do not hardcode currency in the sponsorship agreement template. Add a hint for adding the currency to the amount fields.

#2 @tyxla
2 years ago

  • Keywords has-patch added; needs-patch removed

I've attached a patch for this one. It suggests the following approach (as discussed on Slack in #meta-wordcamp):

  • Don't hardcode the currency (US $) in the sponsorship agreement template.
  • Add a hint to both amount fields that currency name (and currency symbol) should be added to the amounts.

This approach seems easier to me, because this way we don't need to care about the position of the currency symbol (whether it's before or after the amount).

#3 @coreymckrill
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 5607:

WordCamp Docs: Allow non-USD currencies in sponsorship agreement

This simply removes the hard-coded "$US" from the template and adds
notes to the generation form asking the user to include the currency
type when they enter values. This makes it possible to generate a
sponsorship agreement that specifies a local currency.

Fixes #2914
Props tyxla

Note: See TracTickets for help on using tickets.