Opened 7 years ago

Closed 4 years ago

#2918 closed enhancement (wontfix)

Improve processes related to uploading a patch

Reported by: flixos90's profile flixos90 Owned by:
Milestone: Priority: normal
Component: Trac Keywords:


As discussed in recent multisite office hours and then dev chat, it would be great if we could improve the processes that need to happen after uploading a patch to a Trac ticket.

The initial idea was to automatically add the has-patch keyword once a new patch is uploaded and the keyword has not been set before. Even though a patch does not always fix the issue described in the ticket properly, the keyword should always be applied initially (before someone else possibly reviews the patch and changes the keywords again).

However, there was criticism about that idea expressed by @jorbin, since people sometimes upload a wrong patch, then delete it and reupload a new one. This is a valid point, however I'm not sure if that's even a problem. If a patch is deleted and then reuploaded with the same name, it should not matter. It's something to further think about though.

The alternative (or even complementary) approach is to somewhere show a note to briefly highlight what a contributor should do after uploading a patch, which currently is often not clear. It could be a notice such as "Please comment on the ticket, and briefly describe what the patch does. If you enhanced a previous patch, describe what you changed from that patch.". This is not only important for communication about the changes itself, but also so that people are pinged (as the patch upload itself does not trigger a ping).

Change History (2)

#1 @netweb
7 years ago

Trac currently doesn't send email notifications after a patch has been uploaded, so if the keyword has-patch is added automatically then anyone who is watching the ticket will not receive a notification that a patch has been added to the ticket.

As such going for the latter approach mentioned above would be required now to trigger a Trac notification email

A Trac update is available in #1606 that includes an update to send email notifications when an attachment is uploaded


  • #1606 Update Trac to 1.0.14
  • #1608 Trac: Enhance uploading attachments

#2 @dd32
4 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

I'm going to close this one as wontfix. Adding keywords after a file upload isn't as straight forward as one would hope, and with the recently added GitHub PR workflow, it's probably worthwhile using that in future.

Note: See TracTickets for help on using tickets.