WordPress.org

Making WordPress.org

Changes between Initial Version and Version 1 of Ticket #2952, comment 5


Ignore:
Timestamp:
08/29/2017 01:56:40 PM (23 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2952, comment 5

    initial v1  
    11Per the [https://wordpress.slack.com/archives/C60K3MP2Q/p1500922170541761 latest #core-php meeting], the current patch should be good to go, with an announcement on make/plugins upon commit.
    22
    3 A point was raised that adding a "tested up to" PHP version, as suggested by @jb510 in comment:17:ticket:40934 and @joyously in comment:29:ticket:40934, might also be beneficial, but that can be explored in a new ticket and should not prevent the `Minimum PHP` header from being committed.
     3A point was raised that adding a "tested up to" PHP version, as suggested by @jb510 in [https://core.trac.wordpress.org/ticket/40934#comment:17 40934#comment:17] and @joyously in [https://core.trac.wordpress.org/ticket/40934#comment:29 40934#comment:29], might also be beneficial, but that can be explored in a new ticket and should not prevent the `Minimum PHP` header from being committed.
    44
    55That said, I've asked for some additional feedback on new header names. the current patch uses `Mininum PHP: x.x`, as that's what was initially suggested in #WP23880. Given the potential addition of a "tested up to" PHP version header in the future, I think it would make sense to mirror the WP version headers: `Requires` or `Requires at least` and `Tested` or `Tested up to`. Maybe `Requires PHP: x.x` and `Tested PHP: x.x`?