WordPress.org

Making WordPress.org

Opened 5 months ago

Closed 5 months ago

#2957 closed defect (fixed)

Breathe: Submenu and mobile menu issues

Reported by: SergeyBiryukov Owned by:
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: has-screenshots
Cc:

Description (last modified by SergeyBiryukov)

https://make.wordpress.org/accessibility/ was recently switched to the new Breathe theme.

The team noticed a few issues with the menu:

  • "Get Involved" submenu is displayed horizontally, in white text on white background.
  • "Accessibility Handbook" link is inaccessible on mobile.

See the screenshots.

Attachments (2)

2957.png (17.5 KB) - added by SergeyBiryukov 5 months ago.
2957.2.png (29.2 KB) - added by SergeyBiryukov 5 months ago.

Download all attachments as: .zip

Change History (10)

@SergeyBiryukov
5 months ago

#1 @SergeyBiryukov
5 months ago

  • Description modified (diff)

This ticket was mentioned in Slack in #accessibility by sergey. View the logs.


5 months ago

#3 @Otto42
5 months ago

Re: menu, I don't think that theme has support for sub-items or drop down menus like that. Such support could be added, but it's not there now. Don't think any other team has menus with sub-items like that.

#4 @xkon
5 months ago

Just a really really quick fix if you want to make it work until further improvements out of my head would be this

.sub-menu {
    display:inline-block;
    position:absolute;
    list-style-type:none;
}
.sub-menu li {
    clear: bloth !important;
    display:block !important;
}
.sub-menu li a {
    background: #0073AA !important;
    color: #fff !important;
}

I'm writing from my phone so can't make a proper diff atm. Just trying to help. It won't be fully pretty but it'll work.

This is for the white submenu on big viewports. I can check and rework everything when I get home though :) .

Best regards,
Konstantinos

Last edited 5 months ago by xkon (previous) (diff)

This ticket was mentioned in Slack in #meta by sami.keijonen. View the logs.


5 months ago

This ticket was mentioned in Slack in #meta by sergey. View the logs.


5 months ago

#7 @SergeyBiryukov
5 months ago

Comparing https://make.wordpress.org/core/ vs. https://make.wordpress.org/accessibility/, looks like Jetpack's genericons.css is not enqueued on the latter, as well as quite a few styles from the o2 plugin. This explains the missing hamburger icon and potentially other menu issues.

Can someone check if the o2 plugin is activated on https://make.wordpress.org/accessibility and if not, activate it?

#8 @SergeyBiryukov
5 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Activating the plugin appears to have resolved the issues.

Note: See TracTickets for help on using tickets.