Opened 8 years ago
Closed 8 years ago
#2957 closed defect (bug) (fixed)
Breathe: Submenu and mobile menu issues
Reported by: | SergeyBiryukov | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Make (Get Involved) / P2 | Keywords: | has-screenshots |
Cc: |
Description (last modified by )
https://make.wordpress.org/accessibility/ was recently switched to the new Breathe theme.
The team noticed a few issues with the menu:
- "Get Involved" submenu is displayed horizontally, in white text on white background.
- "Accessibility Handbook" link is inaccessible on mobile.
See the screenshots.
Attachments (2)
Change History (10)
This ticket was mentioned in Slack in #accessibility by sergey. View the logs.
8 years ago
#4
@
8 years ago
Just a really really quick fix if you want to make it work until further improvements out of my head would be this
.sub-menu { display:inline-block; position:absolute; list-style-type:none; } .sub-menu li { clear: bloth !important; display:block !important; } .sub-menu li a { background: #0073AA !important; color: #fff !important; }
I'm writing from my phone so can't make a proper diff atm. Just trying to help. It won't be fully pretty but it'll work.
This is for the white submenu on big viewports. I can check and rework everything when I get home though :) .
Best regards,
Konstantinos
This ticket was mentioned in Slack in #meta by sami.keijonen. View the logs.
8 years ago
This ticket was mentioned in Slack in #meta by sergey. View the logs.
8 years ago
#7
@
8 years ago
Comparing https://make.wordpress.org/core/ vs. https://make.wordpress.org/accessibility/, looks like Jetpack's genericons.css
is not enqueued on the latter, as well as quite a few styles from the o2
plugin. This explains the missing hamburger icon and potentially other menu issues.
Can someone check if the o2
plugin is activated on https://make.wordpress.org/accessibility and if not, activate it?
Re: menu, I don't think that theme has support for sub-items or drop down menus like that. Such support could be added, but it's not there now. Don't think any other team has menus with sub-items like that.