Opened 7 years ago
Closed 7 years ago
#2979 closed defect (bug) (fixed)
fix for multiple placeholders should be ordered
Reported by: | afzalmultani | Owned by: | coffee2code |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Developer Hub | Keywords: | has-patch |
Cc: |
Description
Multiple placeholders should be ordered. Expected '%1$s, %2$d', but got %s, %d.
Attachments (3)
Change History (7)
#2
follow-up:
↓ 3
@
7 years ago
- Keywords has-patch added
Hi @afzalmultani, thanks for the patch.
'Used by <a href="%s">1 function</a>'
and 'Used by <a href="%s">%d functions</a>'
are separate strings, the placeholders are not really interchangeable here and don't necessarily have to be numbered.
2979.2.diff appears to treat them as a single string, making the result invalid:
'Used by <a href="%1$s"> function</a>'
is missing the%2$d
placeholder with the number of functions.'Used by <a href="%2$d"> functions</a>'
is missing the%1$s
placeholder with the permalink.
That said, this block needs a few other adjustments:
- Replace
1 function
with a placeholder. Some languages use the singular form for other numbers. - Add translator comments.
- Replace the non-existing
#usage
anchor. Since [3626], it's either#used-by
or#uses
.
Addressed in 2979.3.diff.
Note: See
TracTickets for help on using
tickets.
fix for multiple placeholders should be ordered