fix for multiple placeholders should be ordered

[afzalmultani]

Multiple placeholders should be ordered. Expected '%1$s, %2$d', but got %s, %d.

[afzalmultani]

fix for multiple placeholders should be ordered

[afzalmultani]

UPdated

[SergeyBiryukov]

Hi @afzalmultani, thank for the patch.

'Used by <a href="%s">1 function</a>' and 'Used by <a href="%s">%d functions</a>' are separate strings, the placeholders are not really interchangeable here and don't necessarily have to be numbered.

2979.2.diff​ appears to treat them as a single string, making the result invalid:

• 'Used by <a href="%1$s"> function</a>' is missing the %2$d placeholder with the number of functions.
• 'Used by <a href="%2$d"> functions</a>' is missing the %1$s placeholder with the permalink.

That said, this block needs a few other adjustments:

• Replace 1 function with a placeholder. Some languages ​use the singular form for other numbers.
• Add translator comments.
• Replace the non-existing #usage anchor. Since [3626], it's either #used-by or #uses.

[afzalmultani]

Hi @SergeyBiryukov,

Thanks for the patch and explanation. Definitely, it will help me a lot.

[coffee2code]

In 5721:

developer.wordpress.org: Improve translatability of "Used By"/ "Uses" string.

• Use placeholder instead of hardcoding 1 in string.
• Use numbered placeholders, with comments for translators.
• Update link anchor targets to #used-by/#uses, respectively.

Props SergeyBiryukov.
Fixes #2979.