WordPress.org

Making WordPress.org

Opened 5 months ago

Last modified 2 weeks ago

#3003 accepted defect

Tagregator - Twitter resets settings randomly

Reported by: xkon Owned by: coreymckrill
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: needs-patch
Cc:

Description (last modified by SergeyBiryukov)

Hello,

While I was working on these tickets: #2100 and #2907

I've noticed that my error log was getting grumpy and I saw this error:

[22-Jul-2017 11:26:20 UTC] PHP Notice: Undefined index: consumer_key in tggr-source-twitter.php on line 152

For some reason when you view the results page on the front end the twitter module bugs out randomly ( not all times ) and after that php error all the settings are getting reset so you are losing all login information etc.

I haven't been able to find out why.

@dipeshkakadiya is on it for a solution so we can implement it on gwtd3 new website as well.

Pointers for devs:
Grab the /trunk of Tagregator through svn, apply the extra patches to have the latest as they have not been implemented yet and then work on this ticket.

Attachments (3)

3003.diff (8.7 KB) - added by dipesh.kakadiya 5 months ago.
Fixed #2100 and #2907 and Setting reset on data fetch
3003.1.diff (2.5 KB) - added by dipesh.kakadiya 5 months ago.
Fixed issue of reset setting on new data fetch
3003.2.diff (1.8 KB) - added by xkon 5 months ago.
Modified .diff ( instagram addressed already on previous ticket )

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
5 months ago

  • Description modified (diff)

This ticket was mentioned in Slack in #meta by xkon. View the logs.


5 months ago

@dipesh.kakadiya
5 months ago

Fixed #2100 and #2907 and Setting reset on data fetch

@dipesh.kakadiya
5 months ago

Fixed issue of reset setting on new data fetch

@xkon
5 months ago

Modified .diff ( instagram addressed already on previous ticket )

#3 @xkon
5 months ago

3003.2.diff is the last .diff for a complete revamp of Tagregators API's and errors.

Please do the patches in this order as the issues where all addressed in this order as well to not have issues and conflicts:

1) #2100
2) #2907
3) #3003

Best regards,
Konstantinos

#4 @coreymckrill
5 months ago

  • Owner set to coreymckrill
  • Status changed from new to accepted

This ticket was mentioned in Slack in #meta-wordcamp by coreymckrill. View the logs.


3 months ago

#6 @iandunn
2 weeks ago

I haven't looked closely at this, but can you reproduce this error on trunk? If not, then it may be that one of those patches is getting tripped up by how the settings get validated by TGGRSettings for each of the modules. That class is probably trying to be a little too clever, which makes things more convoluted than they need to be. e.g., maintain_nested_settings().

Note: See TracTickets for help on using tickets.