WordPress.org

Making WordPress.org

Changes between Initial Version and Version 2 of Ticket #3011


Ignore:
Timestamp:
07/29/2017 11:16:42 PM (3 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3011

    • Property Keywords has-patch added
  • Ticket #3011 – Description

    initial v2  
    88
    99Changing the slug to another existing plugin's slug should be disallowed.
     10
     11Some technical details: this happens because [https://core.trac.wordpress.org/browser/tags/4.8/src/wp-includes/post.php?marks=3673,3674#L3657 wp_unique_post_slug()] bails early when dealing with a pending post. Both [https://core.trac.wordpress.org/browser/tags/4.8/src/wp-admin/includes/post.php?marks=1232-1236#L1231 get_sample_permalink()] and [https://core.trac.wordpress.org/browser/tags/4.8/src/wp-admin/includes/ajax-actions.php?marks=1720-1724#L1719 wp_ajax_inline_save()] have a hack to prevent that by faking a`'publish'` status, but `get_sample_permalink()` does not run on Edit Plugin screen, so some additional checks are needed.