Making WordPress.org

Opened 7 years ago

Closed 7 years ago

#3029 closed task (blessed) (fixed)

Plugin Directory: Introduce UI for managing plugin support reps

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: otto42's profile Otto42
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: has-patch has-screenshots
Cc:

Description (last modified by SergeyBiryukov)

Background: #2699

Some of the larger plugin/theme shops have a support team to help out on the forums. It would be useful to be able to give those people a special "support rep" role so they could be recognized as such.

Support staff can mark topics as resolved or sticky (same as plugin authors and contributors), but doesn't have commit access.

In order to implement this, Plugin Directory needs a UI for managing the plugin's support staff. The attached patch implements a UI similar to managing committers on the Advanced view.

Attachments (2)

3029.patch (36.6 KB) - added by SergeyBiryukov 7 years ago.
3029.PNG (20.6 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (14)

@SergeyBiryukov
7 years ago

@SergeyBiryukov
7 years ago

#1 @SergeyBiryukov
7 years ago

  • Description modified (diff)

#2 @Otto42
7 years ago

  • Owner set to Otto42
  • Status changed from new to assigned

#3 @SergeyBiryukov
7 years ago

The patch adds a plugin_support_reps taxonomy for integration with the forums in #2699, and builds on the existing code for managing committers, so while it may seem like there's a lot of new code, it's not really new :)

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


7 years ago

#5 @SergeyBiryukov
7 years ago

@Otto42 On committing, I'd suggest using svn cp or TortoiseSVN UI to copy the existing files to new names:

admin/list-table/class-committers.php → admin/list-table/class-support-reps.php
admin/metabox/class-committers.php → admin/metabox/class-support-reps.php
api/routes/class-plugin-committers.php → api/routes/class-plugin-support-reps.php
widgets/class-committers.php → widgets/class-support-reps.php
widgets/js/committers.js → widgets/js/support-reps.js

And then overwriting those new files with the ones from the patch.

That way the files will preserve the existing commit history and only show the actual changes in SVN blame rather than appear as completely new files. Not a big deal, but seems cleaner.

#6 @SergeyBiryukov
7 years ago

In 5867:

Plugin Directory: Introduce UI for managing plugin support reps.

Support representatives can mark forum topics as resolved or sticky (same as plugin authors and contributors), but don't have commit access to the plugin.

See #3029, #2699.

This ticket was mentioned in Slack in #polyglots by sergey. View the logs.


7 years ago

#8 follow-up: @SergeyBiryukov
7 years ago

@webdevmattcrom noted in #meta that adding a support rep doesn't work for accounts that have an email as a username (benmeredithgmailcom in that case). The error is: The provided user could not be found. Adding the same user by email worked fine.

I think special characters are no allowed in WP.org usernames, but it would be great to fix this for older accounts that might be affected.

Version 0, edited 7 years ago by SergeyBiryukov (next)

#9 @SergeyBiryukov
7 years ago

In 5910:

Plugin Directory: Clear support reps cache when adding or deleting a support rep.

See #3029.

#10 in reply to: ↑ 8 @SergeyBiryukov
7 years ago

adding a support rep doesn't work for accounts that have an email as a username (benmeredithgmailcom in that case). The error is: The provided user could not be found.

The same applies to committers, moved to a separate ticket: #3133.

#11 @SergeyBiryukov
7 years ago

In 5930:

Plugin Directory: Allow for adding committers and support reps by a slug or email, as the input suggests.

Fixes #3133. See #3029.

#12 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.