WordPress.org

Making WordPress.org

Opened 4 months ago

Closed 4 months ago

#3041 closed defect (fixed)

Multiple time same media in the main.css

Reported by: sagarprajapati Owned by: coffee2code
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch
Cc:

Description

In the https://developer.wordpress.org/wp-content/themes/pub/wporg-developer/stylesheets/main.css style file, there is multiple time same media tag.

@media (min-width: 571px) {
  .single-command .btn-group > a:first-child {
    right: -6px;
    border-radius: 3px 0 0 3px;
  }
}

@media (min-width: 571px) {
  .single-command .btn-group > a:last-child {
    border-radius: 0 3px 3px 0;
  }
}

After remove multiple @media:

@media (min-width: 571px) {
  .single-command .btn-group > a:first-child {
    right: -6px;
    border-radius: 3px 0 0 3px;
  }
  .single-command .btn-group > a:last-child {
    border-radius: 0 3px 3px 0;
  }
}

Attachments (2)

3041.diff (717 bytes) - added by sagarprajapati 4 months ago.
3041.2.diff (1.2 KB) - added by SergeyBiryukov 4 months ago.

Download all attachments as: .zip

Change History (5)

@sagarprajapati
4 months ago

#1 @sagarprajapati
4 months ago

  • Keywords has-patch added

Attached patch. Check it.

#2 @SergeyBiryukov
4 months ago

Introduced in [5768].

3041.diff is not complete, as stylesheets/main.css is auto-generated by SASS.

scss/main.scss should be patched instead, see 3041.2.diff.

#3 @coffee2code
4 months ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 5836:

developer.wordpress.org: Merge adjacent CSS @media styles into same block.

Props SergeyBiryukov, sagarprajapati.
Fixes #3041.

Note: See TracTickets for help on using tickets.