Opened 7 years ago

Closed 7 years ago

#3073 closed defect (bug) (fixed)

Plugin Directory: Display plugin's SVN repository link for logged-out users as well

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: coffee2code's profile coffee2code
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: has-patch


In [5218] plugin's SVN repository link was removed as a part of the redesign.

In [5325] it was re-added as an important piece of information under "Interested In Development" section.

However, the link was restored for logged-in users only, as a compromise between showing it to non-technical users and not showing it to developers (both options were less than ideal).

In retrospect, it does not make sense to limit the SVN link to logged-in users. It should be displayed for everyone interested in development, as the section title suggests. If you want to quickly browse the plugin code, readme, or tags, Trac link allows for that as well, but its loading times are significantly slower than SVN, leading to bad UX.

Attachments (1)

3073.patch (1.3 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (5)

7 years ago

#1 @Otto42
7 years ago

Why? Since they can't contribute without a login, then I don't understand this reasoning.

To be fair, most things are public, so it's just "hidden" by accident, not design, but I don't see a lot of value in making things available without login. Just curious for a superficial reason.

Hiding things like SVN and other "technical" systems from drive by users makes sense to me. So, I'm looking for a reason to show those to randoms.

Last edited 7 years ago by Otto42 (previous) (diff)

#2 @SergeyBiryukov
7 years ago

It's not so much about contributing, more about quickly checking the plugin's code quality before installing. As I noted above, Trac link allows for that as well, but it can take up to ten seconds or even more to load, SVN is much faster.

The section is titled "Interested In Development?" and should list all the relevant links. The only thing in that section depending on being logged in is the email subscription link.

#3 @coffee2code
7 years ago

If we're already showing the link to Trac and offering for them to "browse the code", I don't think there's any benefit to holding back a link to the SVN repo. And for the reasons Sergey cited, for those not constantly logged into, it's handy to have the link available to view the source via a more performant avenue.

#4 @coffee2code
7 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 5920:

Plugin Directory: Show plugin's SVN repository link for logged-out users as well.

Props SergeyBiryukov.
Fixes #3073.

Note: See TracTickets for help on using tickets.