![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 9 years ago
Closed 9 years ago
#3077 closed defect (bug) (fixed)
Add missing singular placeholder in comments.php wordpress.tv
| Reported by: | afzalmultani | Owned by: | coffee2code |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | WordPress.tv | Keywords: | has-patch |
| Cc: |
Description
Missing singular placeholder, needed for some languages.
Attachments (2)
Change History (4)
#1
@
9 years ago
- Keywords has-patch added
For a bit more context, the suggested pattern is recommended for languages that use the singular form for other numbers (e.g. 21, 31 and so on), see https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals.
It's now implemented in Twenty Sixteen and Twenty Seventeen, and should be added to older bundled themes as well in #WP39660.
3077.diff looks good, the only issue is that get_comments_number() returns a string and should not be strictly compared to an integer.
3077.2.diff fixes that and removes unrelated formatting changes.
Version 0, edited 9 years ago by
(next)
Note:
See TracTickets
for help on using tickets.
Missing singular placeholder