Opened 10 years ago

Closed 10 years ago

#309 closed defect (bug) (fixed)

Prevent caching of P2 iPhone styles

Reported by: nacin's profile nacin Owned by: nacin's profile nacin
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords:


P2 selectively serves a stylesheet for iPhones, designed to be read in portrait mode (based on its penchant for 320px). The problem is it does this by sniffing the user agent, thus tripping up's load balancers, which means desktops are sometimes served an iPhone style. It also doesn't drop a cookie for the LBs to be configured to ignore.

This commit will make our child theme re-register the iPhone stylesheet with a media query of max-width: 320px. It will also simply always enqueue this stylesheet, thus bypassing the UA sniffing, and allowing it to be served to other narrow mobile devices.

Ideally as more of is made responsive we can just do away with this stylesheet, which is a pretty old hack in and of itself.

Change History (1)

#1 @nacin
10 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 379: P2: Re-register P2's iPhone styles with a media query, to avoid it from being served to desktops in caching situations. fixes #309.

Note: See TracTickets for help on using tickets.