WordPress.org

Making WordPress.org

Opened 3 weeks ago

Last modified 8 days ago

#3105 new defect

Wrong colors on second menu (unreadable)

Reported by: Mte90 Owned by:
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: needs-patch
Cc:

Description

As you can see on https://it.wordpress.org/team/ and when you go with the mouse on Community in the blue header the submenu is blank.
As I can see is only a css problem that is easy to fix :-)

Attachments (2)

Screenshot_20170906_104121.png (16.7 KB) - added by Mte90 3 weeks ago.
screenshot
3105.diff (877 bytes) - added by xkon 8 days ago.
disable wporg-breathe header submenus

Download all attachments as: .zip

Change History (13)

@Mte90
3 weeks ago

screenshot

This ticket was mentioned in Slack in #meta by mte90. View the logs.


3 weeks ago

#2 @netweb
3 weeks ago

  • Keywords close added

Via https://meta.trac.wordpress.org/ticket/1066#comment:6
Replying to samuelsidler:

... sub-menus won't be supported on Rosetta. Eventually, dotorg will not have them either.

#3 @danieltj
3 weeks ago

  • Keywords close removed

As per this comment (https://meta.trac.wordpress.org/ticket/1066#comment:9), this still needs fixing whilst they're there and in case they are used in future.

I'll see if I can take a look at this at some point tonight. I suggest we open this for a fix.

#4 @SergeyBiryukov
3 weeks ago

Previously mentioned in #2957, the workaround there was to remove the submenu.

@xkon suggested some styles that could be used as a first pass at a fix.

#5 @xkon
3 weeks ago

This has multiple sub-levels, the #2957 was dealing with 1 only if i remember correctly.

Just with chrome inspection this would at least make the sub-menus blue and viewable. Unfortunately I don't have access to my VVV atm to check it further but it's a good start at least if someone wants to jump in as well so hope this helps.

The idea was though that there shouldn't be any submenus from the past discussions, so if they are meant to stay better come up with a permanent solution and check everything ( responsive or not etc ). This is not checked on the mobile menu so be alarmed. I'll check everything this afternoon when I get home if nobody else has done already :)

.navigation-main .sub-menu {
    text-align: left;
    border: 0 !important;
    position: absolute;
}

.navigation-main .navigation-main .sub-menu li {
    clear: both !important;
    display: block !important;
}

.navigation-main .sub-menu li a {
    background: #0073AA !important;
    color: #fff !important;
    text-decoration: none !important;
}
Last edited 3 weeks ago by xkon (previous) (diff)

#6 @SergeyBiryukov
11 days ago

On second thought, re-reading #1066, we could just add 'depth' => 1 to the wp_nav_menu() call.

Rosetta theme has a function to limit the depth to top-level items in the admin, I guess it should be added to the wporg-breathe theme as well.

#7 follow-up: @netweb
11 days ago

If the proposed design goals are to not have submenus then both here in this ticket and in #1066 the resolution should be to remove the submenu items from the sites concerned and not a code change that facilitates and enables the usage of submenus

#8 in reply to: ↑ 7 ; follow-up: @SergeyBiryukov
10 days ago

Replying to netweb:

the resolution should be to remove the submenu items from the sites concerned and not a code change that facilitates and enables the usage of submenus

The change proposed in comment:6 disables the usage of submenus, same as in comment:2:ticket:1066.

Last edited 10 days ago by SergeyBiryukov (previous) (diff)

#9 in reply to: ↑ 8 @netweb
10 days ago

Replying to SergeyBiryukov:

Replying to netweb:

the resolution should be to remove the submenu items from the sites concerned and not a code change that facilitates and enables the usage of submenus

The change proposed in comment:6 disables the usage of submenus, same as in comment:2:ticket:1066.

Right, misread +1

@xkon
8 days ago

disable wporg-breathe header submenus

#10 follow-up: @xkon
8 days ago

Although I was trying to find a way to add a 'blue' menu on my VVV without luck I think this would be the correct source to change, I tried with the es. / en. / jp., probably I'm missing a setting or something but anyway.

Also I've seen that the wporg-p2 doesn't have a depth limit as well should we add it there as well? The p2 menu should be the same header menu as on this page ( Blog, Trac ) and it does support submenus currently.

I'm not adding has-patch yet as I'm working blindly here for now so @SergeyBiryukov / @netweb if you could have a look on 3105.diff it would be great.

#11 in reply to: ↑ 10 @netweb
8 days ago

Replying to xkon:

Also I've seen that the wporg-p2 doesn't have a depth limit as well should we add it there as well? The p2 menu should be the same header menu as on this page ( Blog, Trac ) and it does support submenus currently.

I don't think the wporg-p2 theme is used on any Rosetta sites anymore so the changes for it are not required

Note: See TracTickets for help on using tickets.