Making WordPress.org

Opened 7 years ago

Closed 6 years ago

Last modified 5 years ago

#3114 closed defect (bug) (fixed)

The credits API responds with latest version data for old versions

Reported by: johnbillion's profile johnbillion Owned by: obenland's profile obenland
Milestone: Priority: normal
Component: API Keywords: needs-patch
Cc:

Description

The response to requesting https://api.wordpress.org/core/credits/1.1/?version=3.1 and earlier versions is credits data for the latest version of WordPress, but this is not immediately obvious unless you check the data.version property.

Requests for credits information prior to 3.2 should respond with something more appropriate, for example a 404.

Change History (5)

#1 follow-up: @SergeyBiryukov
7 years ago

Related: #577

Maybe we could parse the props and backfill the credits data for older releases?

#2 @johnbillion
7 years ago

Yeah backfilling the older versions' data would be great

#3 @obenland
6 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 7300:

Credits: Bail for credits prior to 3.2.

There are no credits for versions earlier than that.

Props johnbillion.
Fixes #3114.

This ticket was mentioned in Slack in #meta by sergey. View the logs.


5 years ago

#5 in reply to: ↑ 1 @SergeyBiryukov
5 years ago

Replying to SergeyBiryukov:

Maybe we could parse the props and backfill the credits data for older releases?

Follow-up: #4697

Note: See TracTickets for help on using tickets.