WordPress.org

Making WordPress.org

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#3139 closed defect (wontfix)

Insert target blank in visit site

Reported by: lalitpendhare Owned by:
Milestone: Priority: normal
Component: Showcase Keywords: has-patch
Cc:

Description

I have just seen a WordPress showcase(https://wordpress.org/showcase/bata/) and I have just click on visit site button. Here I have seen that I have gone to the site but on the same page. As per the site standard, I thought, the link is open on another tab. so here I have fixed this.

The file is located in "https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-showcase/single.php" and my changes on line 58.

Attachments (1)

3139.patch (634 bytes) - added by lalitpendhare 4 months ago.
insert target blank in visit site link

Download all attachments as: .zip

Change History (4)

@lalitpendhare
4 months ago

insert target blank in visit site link

#1 @Otto42
4 months ago

  • Resolution set to wontfix
  • Status changed from new to closed

Negative. If you want to open the link in a new tab, you can middle-click or control-click or whatever keyboard shortcut is appropriate for your browser. We do not want target=_blank on these links, as it is an anti-pattern (in breaking the contextual flow of the "Back" button), and also a potential vulnerability without adding rel="noopener noreferrer" as well.

#2 @Otto42
4 months ago

  • Component changed from General to Showcase

#3 @SergeyBiryukov
4 months ago

Hi @lalitpendhare, welcome to WordPress Meta Trac! Thanks for the ticket.

As noted above, automatically opening links in a new tab should be avoided. It's also bad for accessibility:

Avoid target="_blank" in your links. It can be confusing to all types of users, especially for visually impaired folks. They can wind up with all sorts of open tabs that they don’t even know about. Leave the control of whether the link opens in the same window or in another tab in the hands of users.

Last edited 4 months ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.