Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#3156 closed defect (bug) (fixed)

WordCamp Base theme: Add missing singular placeholder in comments.php

Reported by: mp518's profile mp518 Owned by: mp518's profile mp518
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: has-patch

Description (last modified by coreymckrill)

Add missing singular placeholder in the comments template, it's needed for some languages.

Attachments (2)

3156.patch (6.1 KB) - added by mp518 7 years ago.
3156.2.patch (1.2 KB) - added by mp518 7 years ago.

Download all attachments as: .zip

Change History (8)

7 years ago


#1 @coreymckrill
7 years ago

  • Description modified (diff)
  • Owner set to mp518
  • Status changed from new to assigned
  • Summary changed from wordcamp : Add missing singular placeholder in comments.php to WordCamp Base theme: Add missing singular placeholder in comments.php

Thanks for the patch, @mp518 ! It looks like it has a lot of unnecessary/irrelevant code indentation changes in it. Could you update it so that it only includes the placeholder change?

7 years ago


#2 @mp518
7 years ago

Hey @coreymckrill,
Please Look it.

This ticket was mentioned in Slack in #meta-wordcamp by coreymckrill. View the logs.

7 years ago

#4 @coreymckrill
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 5972:

WordCamp Base: Add missing singular placeholder

Some languages use a singular form for other numbers besides "1",
e.g. "21" in Russian. This follows the same strategy used in _s
to make the translations compatible.

Fixes #3156
Props mp518, coreymckrill

#5 @coreymckrill
7 years ago

@mp518 Thanks again for the patch. For future reference, you can see that in the r5972 commit I updated your code a bit to conform to WordPress PHP coding standards.

#6 @coreymckrill
7 years ago

In 5973:

WordCamp Base: Make sure comment number comparison works as expected

From @sergeybiryukov:

get_comments_number() returns a numeric string, strictly comparing
it to an integer doesn't work as expected

This emulates Twenty Seventeen, which handles the comparison correctly.

Refs #3156

Note: See TracTickets for help on using tickets.