WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 23 months ago

#3168 closed defect (fixed)

WordPress.tv: Too small font size in handbook menu

Reported by: SergeyBiryukov Owned by: coffee2code
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: has-screenshots
Cc:

Description

The sidebar menu on https://make.wordpress.org/tv/handbook/ has a few issues:

  1. The font is too small (10px) when compared to other handbooks like Core Contributor Handbook (13px).
  2. A search form should be added above the Chapters menu for consistency with other handbooks.

Looking at the markup, the first issue has to do with WPTV handbook using a custom menu instead of the Handbook Pages widget. The widget uses a specific font size:

#secondary aside.widget_wporg_handbook_pages {
    font-size: 16px;
}

The WPTV custom menu uses the default P2-Breathe font size, which is too small here:

#secondary aside {
    font-size: 1.2em;
}

The easiest fix is probably to use the Handbook Pages widget, same as other handbooks do.

Attachments (2)

3168.wptv-handbook-menu.PNG (8.6 KB) - added by SergeyBiryukov 2 years ago.
3168.core-handbook-menu.PNG (8.4 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
2 years ago

  • Keywords has-screenshots added

#2 follow-up: @juanfra
2 years ago

Hi @SergeyBiryukov,

I hope all is well.

They are both using the same theme (wporg-breathe). It seems like a widget configuration problem. The toggle functionality isn't working either.

I can see the class .widget_wporg_handbook_pages in the contributor's handbook, whereas the one in the TV handbook seems to be using the navigation widget (.widget_nav_menu).

Do you have access to check the widget configuration there? I think that will solve both style and toggle.

Cheers,
Juan.

This ticket was mentioned in Slack in #wptv by sergey. View the logs.


2 years ago

#4 in reply to: ↑ 2 @SergeyBiryukov
2 years ago

Replying to juanfra:

I can see the class .widget_wporg_handbook_pages in the contributor's handbook, whereas the one in the TV handbook seems to be using the navigation widget (.widget_nav_menu).

Yes, exactly. As I said in the ticket, using the Handbook Pages widget instead of a custom menu is probably the easiest fix :)

Do you have access to check the widget configuration there? I think that will solve both style and toggle.

No. Asked in #wptv on Slack for someone to take a look.

#5 @juanfra
2 years ago

Thanks for the prompt response :)

Yes, I concur. I thought you might have access, that's why I was asking. Let's hope somebody with access can help us with this.

Have a great day,
Juan.

#7 @coffee2code
23 months ago

  • Owner set to coffee2code
  • Status changed from new to accepted

#8 @coffee2code
23 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 6272:

Breathe: Fix font size for handbook sidebar menu when generated by Navigation Menu widget.

Fixes #3168.

Note: See TracTickets for help on using tickets.