Making WordPress.org

Opened 4 years ago

Closed 4 years ago

#3186 closed defect (fixed)

P2: Missing bottom margin in search template

Reported by: SergeyBiryukov Owned by: obenland
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: has-screenshots has-patch

Description (last modified by SergeyBiryukov)

If a search returns no results, there's no bottom margin after content, see the screenshot, taken from https://make.wordpress.org/meta/handbook/?s=abbr.

On a related note, new post form should probably be removed from this template. I don't think creating new posts from the search page is a common use case.

Attachments (4)

3186.PNG (40.3 KB) - added by SergeyBiryukov 4 years ago.
3186.patch (56.1 KB) - added by Shital Patel 4 years ago.
search button
before-screenshot-make.wordpress.org-search-button.png (48.7 KB) - added by Shital Patel 4 years ago.
after-screenshot-make.wordpress.org-search-button.png (61.2 KB) - added by Shital Patel 4 years ago.

Download all attachments as: .zip

Change History (8)

4 years ago

#1 @SergeyBiryukov
4 years ago

  • Description modified (diff)

#2 @SergeyBiryukov
4 years ago

The issue exists on blogs like https://make.wordpress.org/meta/ as well, but they have a longer sidebar, so it's easier to reproduce in handbooks.

@Shital Patel
4 years ago

search button

#3 @Shital Patel
4 years ago

  • Keywords has-patch added

#4 @obenland
4 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 6355:

Breathe: Add margin to searchforms in posts.

These almost always show up when no posts can be found, or its a 404.

Props Shital Patel for initial patch.
Fixes #3186.

Note: See TracTickets for help on using tickets.