WordPress.org

Making WordPress.org

Opened 2 months ago

Last modified 7 weeks ago

#3190 new defect

Sponsor Invoices: "paid" emails are coming from multiple sites

Reported by: Varantain Owned by:
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: needs-patch
Cc:

Description

This is from the context of a Sponsor Wrangler, as I haven't had the chance to test it as a Sponsor.

Sponsor "approved" emails (which happen when an invoice is sent to a sponsor) come from wordpress@wordcamp.org, but "paid" emails (which happen when the invoice is marked as paid) come from many different email addresses.

For the Singapore camp this year, I have seen emails arrive from wordpress@2017.lehighvalley.wordcamp.org, wordpress@2017.brisbane.wordcamp.org and wordpress@central.wordcamp.org.

Attachments (1)

3190.patch (663 bytes) - added by SergeyBiryukov 2 months ago.

Download all attachments as: .zip

Change History (7)

#1 @coreymckrill
2 months ago

  • Keywords needs-patch added

#2 @SergeyBiryukov
2 months ago

  • Keywords has-patch added; needs-patch removed

Could be unrelated, but I've noticed that notify_organizer_status_changed() calls switch_to_blog() and then returns without calling restore_current_blog() if $new_status is neither approved nor paid.

I've looked through all switch_to_blog() calls in WordCamp.org plugins and haven't noticed any other instances not followed by restore_current_blog() at a glance.

This ticket was mentioned in Slack in #meta-wordcamp by sergey. View the logs.


8 weeks ago

#4 @iandunn
7 weeks ago

In 6052:

WordCamp Budgets Dashboard: Restore current blog before returning early.

See #3190
Props SergeyBiryukov

#5 @iandunn
7 weeks ago

Thanks @SergeyBiryukov :)

I don't think [6052] will fix the issue, because I'm not seeing that function ever get called without a status without a valid $new_status. The return there is just a way to be extra careful. It's still correct to have the restore_current_blog() there, though.

wp_mail() uses $_SERVER['SERVER_NAME'] to set the From address, which wouldn't be affected by switch_to_blog(). I wonder if that's the cause? If so, we could probably just fix that by setting it in $headers.

#6 @iandunn
7 weeks ago

  • Keywords needs-patch added; has-patch removed
Note: See TracTickets for help on using tickets.