WordPress.org

Making WordPress.org

Opened 7 months ago

Last modified 7 months ago

#3199 reopened enhancement

Pre-fill fields for wcdocs

Reported by: casiepa Owned by: iandunn
Milestone: Priority: low
Component: WordCamp Site & Plugins Keywords: good-first-bug needs-patch
Cc:

Description

Both the 'Attendee Visa letter' and 'Speaker Visa letter' are asking for information that is always the same for any request for the same WordCamp. Fields like 'WordCamp Name, WordCamp Location, WordCamp Date Start, WordCamp Date End, Organizer Name, Organizer Contacts' are the same for every Visa letter request so could be added on a 'settings' page or tab at the start of /wp-admin/admin.php?page=wcdocs

It would save time for bigger WordCamps like WCEU where several requests come in. It would also avoid spelling mistakes, decrease human errors and increase the overall consistency of the documents per WordCamp.

Using wcpt_get_wordcamp_location() to get the information might even be a better way, but for now just some fields to fill the info once would already be great.

Attachments (3)

3199.diff (5.8 KB) - added by casiepa 7 months ago.
3199.2.diff (6.3 KB) - added by casiepa 7 months ago.
Changed as requested
Capture.PNG (64.2 KB) - added by casiepa 7 months ago.

Download all attachments as: .zip

Change History (14)

#1 @coreymckrill
7 months ago

  • Keywords needs-patch good-first-bug added

I agree, this would be a helpful addition. I think get_wordcamp_post(), located in mu-plugins/helper-functions.php would make it fairly easy to grab all the necessary values for pre-populating the fields.

#2 @casiepa
7 months ago

  • Keywords has-patch added; needs-patch removed

Both Speaker and Attendee Visa letter have been adapted. Data is taken using get_wordcamp_post().

This is my first .diff so please doublecheck that it's correct. Thanks.

@casiepa
7 months ago

#3 @grapplerulrich
7 months ago

After just reviewing the code I saw a few things.

  • name="attendee_last_name" should be changed too in speaker-visa.php
  • A small coding standard issue. I would add a space between ! and empty in !empty

Otherwise it looks good!

@casiepa
7 months ago

Changed as requested

#4 @casiepa
7 months ago

Patch 3199.2 has the changes as requested.

#5 @grapplerulrich
7 months ago

The changes look good. I have tested them locally too and was able to generate a PDF with the changes.

As we are adding changes we could add the WordCamp Location and WordCamp Date to the sponsor agreement too.

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


7 months ago

#7 @iandunn
7 months ago

In 6053:

WordCamp Docs: Rename speaker fields from "attendee" to "speaker".

This template was copied and pasted from the attendee template, and the fields were not updated at the time.

See #3199
Props casiepa, grapplerulrich

#8 @iandunn
7 months ago

  • Owner set to iandunn
  • Resolution set to fixed
  • Status changed from new to closed

In 6054:

WordCamp Docs: Pre-populate Speaker and Attendee visas.

Fixes #3199
Props casiepa, grapplerulrich

#9 @iandunn
7 months ago

  • Keywords needs-patch added; has-patch removed
  • Priority changed from normal to low
  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks @casiepa and @grapplerulrich

I'm actually going to re-open this, since we can also populate the fields for the sponsorship agreement, and also pull in the organizer contact info for all the templates.

#10 @casiepa
7 months ago

So what is missing for the sponsorship agreement is:

  • The h2 title
  • The 'WordCamp Date' (which would be a combination of start and end date)
  • The 'WordCamp Location'

But @iandunn what do you mean by 'organizer contact info' ? I suppose you mean the last box of the Visa forms?
What meta data should go in there, would that be the 'Contact Information' one (see screenshot)?

@casiepa
7 months ago

#11 @iandunn
7 months ago

That's right. It'd be the E-mail Address field (not Email Address without the hyphen).

Note: See TracTickets for help on using tickets.