WordPress.org

Making WordPress.org

Opened 9 months ago

Closed 6 months ago

#3204 closed defect (fixed)

i18n: Add translators comment for placeholders used in "review queue" message

Reported by: felipeelia Owned by: obenland
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: needs-patch
Cc:

Description

I've just noticed this while translating some strings of plugins directory. Before the _n in (plugin-directory/shortcodes/class-upload.php:70):

<?php
printf(
        _n(
                'Currently there are %1$s plugins in the review queue, %2$s of which is awaiting its initial review.',
                'Currently there are %1$s plugins in the review queue, %2$s of which are awaiting their initial review.',
                $plugins->new,
                'wporg-plugins'
        ),
        '<strong>' . ( $plugins->new + $plugins->pending ) . '</strong>',
        '<strong>' . $plugins->new . '</strong>'
);

we should have

/* translators: 1: new + pending plugins; 2: new plugins */

or something like that, shouldn't we?

Change History (5)

#1 follow-up: @Otto42
9 months ago

Comments are meant to explain things that are not clear. Is this unclear?

We don't add comments for every case of multiple strings, just the stranger cases.

#2 in reply to: ↑ 1 @danieltj
9 months ago

Replying to Otto42:

Comments are meant to explain things that are not clear. Is this unclear?

We don't add comments for every case of multiple strings, just the stranger cases.

I've seen less stranger cases with comments. Agreed that over explaining doesn't help, but in this case scenario, considering that there's more than one placeholder - it could only help.

#3 @felipeelia
9 months ago

Sorry @Otto42 and @danieltj,

Actually the _n call that is more misleading to me is this one, at line 91:

<?php
_n(
                'You have %1$s plugins in the review queue, %2$s is being actively reviewed. Please wait for them to be approved before submitting any more.',
                'You have %1$s plugins in the review queue, %2$s are being actively reviewed. Please wait for them to be approved before submitting any more.',
                $submitted_counts->pending,
                'wporg-plugins'
),
'<strong>' . $submitted_counts->total . '</strong>',
'<strong>' . $submitted_counts->pending . '</strong>'

English isn't my first language, but I think that a hint for what "actively reviewed" means in this case would help.

#4 @Otto42
9 months ago

I'm happy to add a comment, I just don't know what to add. What is the confusion, exactly?

#5 @obenland
6 months ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 6405:

Plugins: Add translator comments.

Provides more context for strings with placeholders.

Props felipeelia.
Fixes #3204.

Note: See TracTickets for help on using tickets.