Opened 7 years ago

Closed 7 years ago

#3211 closed defect (bug) (invalid)

Cannot redeclare function as JetPack uses that function name already

Reported by: casiepa's profile casiepa Owned by:
Milestone: Priority: normal
Component: Keywords:


Provisionning a local vvv install, I'm getting the following error:

==> default: Fatal error: Cannot redeclare video_image_url_by_guid() (previously declared in /srv/www/wordpress-meta-environment/meta-repository/ in /srv/www/wordpress-meta-environment/meta-repository/ on line 630

Please change the name of the function in the sandbox mu plugin for WPTV.

Change History (4)

This ticket was mentioned in Slack in #meta-wordcamp by casiepa. View the logs.

7 years ago

#2 @SergeyBiryukov
7 years ago

That file only exists in Meta Environment repo on GitHub, so perhaps it should have been reported there, but I guess here is fine as well :)

The function is there as a fallback so it could be used in the_video() and the_video_image() in wptv2 theme without Jetpack, so changing the name doesn't make much sense.

I think it should be moved to the theme itself, with a function_exists() check (a check alone wouldn't be enough, as mu-plugins load earlier than regular plugins).

#3 @grapplerulrich
7 years ago

There is already a PR for this in the meta environment

#4 @casiepa
7 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Closing as GitHub pull request is the way to go.

Note: See TracTickets for help on using tickets.