Zero themes shown on English variations of the Theme Directory

[johnbillion]

When searching for "wordpress themes" on google.co.uk, the top result points to ​https://en-gb.wordpress.org/themes/ which simply shows a No themes found error message. Sad times.

[johnbillion]

Huh, this appears to be an intermittent error. It doesn't actually happen every time.

[Otto42]

It is a known issue that the theme directory occasionally, and rarely, shows only one theme. It's a caching problem which is difficult to track down. Never seen it show zero themes though.

[obenland]

In 6546:

Themes: Add debug snippet to track 1 theme result

See #3215.

[dingo_d]

@obenland Did you get any debug info about this?

[obenland]

So far I haven't gotten anything, no

[dingo_d]

I'm all for closing this then :)

[dd32]

Given this is a known issue, that's still occuring (even if we've not been able to catch it with debug code) it's probably best to leave this open until it ceases to happen / be reported.

[dd32]

In 9524:

Theme Directory: Add some debugging to try to figure out the cause of none, or 1 theme only showing up on the Theme Directory homepage.

See #3215.

[dd32]

In 9525:

Theme Directory: Revert Debug added in r9524.

See #3215.

[dd32]

In 9526:

Theme Directory: Don't use the global $wp_query object when querying themes.

This was causing cached results to be affected by other query params that WP_Query accepts through $_GET.

This will cause an increase in queries on same pages, but should be unnoticed thanks to the heavy caching we employ on these pages.

Debug left in to ignore caches with only 1 result, can be removed in a few hours after all caches expire.

Fixes #3215.

[dd32]

In 9527:

Theme Directory: remove the now not-needed cache debugging code.

See #3215.