Making WordPress.org

Opened 6 years ago

Closed 6 years ago

#3218 closed enhancement (fixed)

Add hint about tags to posting form

Reported by: sterndata's profile sterndata Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Priority: normal
Component: Support Forums Keywords: has-patch
Cc:

Description

People use hashtags, perids, semicolons, etc. Add a hint to the tag field.

Attachments (4)

Selection_001_2017_10_22_17:44:02.png (15.9 KB) - added by sterndata 6 years ago.
like this but formatted nicely.
3218.diff (1.1 KB) - added by Mirucon 6 years ago.
3218.2.diff (6.3 KB) - added by audrasjb 6 years ago.
3218: add help text for topic tags using aria-describedby attribute
3218.3.diff (2.7 KB) - added by Mirucon 6 years ago.
Merged approach from @audrasjb

Download all attachments as: .zip

Change History (11)

@sterndata
6 years ago

like this but formatted nicely.

This ticket was mentioned in Slack in #forums by sterndata. View the logs.


6 years ago

@Mirucon
6 years ago

#2 @Mirucon
6 years ago

  • Keywords has-patch added
  • Type changed from defect to enhancement

+1. Here's my patch and it actually works.

@audrasjb
6 years ago

3218: add help text for topic tags using aria-describedby attribute

#3 @audrasjb
6 years ago

Oh, I didn't seen @Mirucon patch before uploading mine :)

So I think the difference between the two patches:
– mine is using aria-describedby attribute for a better accessibility of this help text
– Mirucon's is using <p> tag and CSS which is great

How about mixing these two approaches? :)

About aria-describedby,see: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-describedby_attribute

Last edited 6 years ago by audrasjb (previous) (diff)

#4 @netweb
6 years ago

Sounds good, but let's only do it for the WordPress.org/support theme:

  • wordpress.org/public_html/wp-content/themes/pub/wporg-support

Let's not do it on the bb-base, bbPress, or BuddyPress themes, also the wporg-forums theme is no longer used so no point updating this theme either, all i18n sites should be using the new theme I now believe.

#5 @Mirucon
6 years ago

Hi @netweb,

So wordpress.org/public_html/wp-content/themes/pub/wporg-support/bbpress/form-reply.php is the correct place, right? Should we add it on wporg-support/bbpress/form-topic.php as well?

I'll be making a new patch and it will merge the approach from @audrasjb's patch.

#6 @audrasjb
6 years ago

Ok, great @netweb !

@Mirucon feel free to ask any help if needed :)

@Mirucon
6 years ago

Merged approach from @audrasjb

#7 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 6050:

Support Theme: Add "Separate tags with commas" hint to "Topic Tags" input.

Props Mirucon, audrasjb, sterndata.
Fixes #3218.

Note: See TracTickets for help on using tickets.