Making WordPress.org

Opened 7 years ago

Closed 7 years ago

#3220 closed task (blessed) (fixed)

Trac: Retire "Press This" component

Reported by: kraftbj's profile kraftbj Owned by:
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

I gardened the "Press This" Trac component, closing or moving everything open out.

Is it time to delete/retire/deactivate it?

https://core.trac.wordpress.org/component/Press+This

Change History (9)

#1 @Clorith
7 years ago

I think we should keep it for at least one release after PT has been moved into a plugin, so that we can catch any issues with the move that may arise. Even though that's been moved to GitHub, not everyone knows this so it makes sense to retain the component if only until 5.0 is out (a few months won't make a big difference).

#2 @obenland
7 years ago

@dd32 Would you mind pairing with me on this?

I'm not sure we really need to wait until April to get this fixed, especially in the light of it already producing PHP warnings.

#3 @dd32
7 years ago

In 6394:

Trac: Don't produce a PHP Warning when there's no tickets in a component.

See #3220.

#4 @dd32
7 years ago

@obenland Sure, although I'm not exactly sure what needs doing to remove this.

I think it's probably just deleting it from Tracs admin, and deleting the page on make/core. There might be a few more locations in JS or other code which checks it too..
Might also need to check in the notification DB tables to remove old entries or something

#5 @obenland
7 years ago

In 6410:

Trac: Remove Press This subcomponent.

See #3220.

#6 @obenland
7 years ago

I trashed the make/core component but don't seem to have access to core trac's admin.

#7 @obenland
7 years ago

@dd32 Could you take over the Trac admin part? I don't have access to that

#8 follow-up: @obenland
7 years ago

I received admin access to Core Trac and removed the Press This component from there as well.

@dd32 Anything else you can think of?

#9 in reply to: ↑ 8 @dd32
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Replying to obenland:

I received admin access to Core Trac and removed the Press This component from there as well.

I was blind and couldn't see the option :) (I now do, Trac's UI is weird)

@dd32 Anything else you can think of?

Looks like you got it all.
Thankfully Trac fixed the bug at some point that means removed components are still assigned to old tickets :) - it used to be it'd get removed from them too, or they'd end up with a numeric id as the component.

Note: See TracTickets for help on using tickets.