WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 3 months ago

Last modified 3 months ago

#3224 closed enhancement (fixed)

Theme Trac: Updates to approved tickets should not create new tickets.

Reported by: poena Owned by: dd32
Milestone: Priority: high
Component: Theme Review Keywords:
Cc:

Description

If a theme ticket is a approved and the theme author (reporter) submits a new version of the theme, a new trac ticket is created.

We would like the update to be in the same ticket instead of a new ticket being created.
It is confusing for authors when new tickets are created and it means extra work for the reviewers.

The status would remain "approved" so that the theme author does not loose their position in the review queue.

Change History (10)

#1 @dingo_d
7 months ago

@dd32 @tellyworth can this be done in trac? If we can help with code we could submit a patch, just point us in the right direction :)

#2 @dd32
7 months ago

This can be done - we know the tickets for the theme, so looking at the last ticket and seeing if it's still in an open state (You'll need to be very specific with what states) and adding a comment instead of creating a new ticket isn't a huge change.

This ticket was mentioned in Slack in #themereview by dingo_d. View the logs.


4 months ago

#4 @dingo_d
4 months ago

  • Priority changed from normal to high

#5 @dd32
4 months ago

To move this forward, as i alluded to last time, can someone confirm the _exact_ statuses that are affected here and the expected outcome.

Links to existing themes that triggered the scenario is also hugely important.

It's a small change to make, but it requires someone more familiar with it to post the exact statuses and dig out examples.

This ticket was mentioned in Slack in #themereview by poena. View the logs.


4 months ago

#7 @poena
4 months ago

The status is approved. (https://themes.trac.wordpress.org/query?status=approved)

When the update is submitted it should be attached to the same ticket, and the status should remain approved.

Asking people with themes in the approved queue to submit updates since there currently are no updates to approved themes...

Last edited 4 months ago by poena (previous) (diff)

#9 @dd32
3 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9198:

Theme Review: When a newer version of an approved theme, that it not yet live is made, update the existing ticket rather than creating a new one.

Fixes #3224.

#10 @dd32
3 months ago

I think [9198] will do it.

It looks like the code was assuming that approved is a live theme, or in the process of being set live (which it kind of is.. but not exactly?)

Please watch the tickets and let me know if this doesn't appear to be working as expected.

Last edited 3 months ago by dd32 (previous) (diff)
Note: See TracTickets for help on using tickets.